Skip to content

FMA: SuperchainWETH #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tynes opened this issue Mar 27, 2025 · 6 comments
Closed

FMA: SuperchainWETH #234

tynes opened this issue Mar 27, 2025 · 6 comments
Assignees

Comments

@tynes
Copy link
Contributor

tynes commented Mar 27, 2025

The following FMA exists for SuperchainWETH: https://github.com/ethereum-optimism/design-docs/blob/f3aa2db64b1676b5e58ae602acf2ebdba34b617c/security/fma-superchainweth.md

This ticket is complete when the FMA is considered finalized.

@tynes
Copy link
Contributor Author

tynes commented Mar 27, 2025

It is currently in implementing actions phase. Given the recent work towards renaming SuperchainWETH to SuperchainETHBridge here, we will want to reevaluate this FMA. At first glance, it appears as if the existing failure modes will be the same and do not need to be modified. cc @tremarkley

Regarding the monitoring action item, we need to decide if a generic "double check all executing messages are valid" sort of monitoring is enough, or if we need to have something specific to check eth balances. I lean towards thinking that just having monitoring around all valid executing messages should be good enough, this assumes that there is no way to unlock the eth from the ETHLockbox without an executing message being created. cc @mds1 @smartcontracts

@agusduha
Copy link
Contributor

Review:

  • FMA1 and FMA2 still relevant for the SuperchainETHBridge changes
  • Monitoring over the Msg Passing FMA seems enough to cover these cases

@tremarkley
Copy link
Contributor

tremarkley commented Mar 31, 2025

Did a review and the existing failure modes should still hold. Created this PR to update the FMA to reference SuperchainETHBridge instead of SuperchainWETH cc @agusduha @tynes

@agusduha
Copy link
Contributor

agusduha commented Apr 2, 2025

Finalizing PR: #250

@op-aaron op-aaron assigned mds1 and unassigned agusduha Apr 8, 2025
@tynes tynes moved this from Backlog to In Review in Protocol Team Apr 11, 2025
@mds1 mds1 assigned smartcontracts and unassigned mds1 Apr 11, 2025
@mds1
Copy link
Contributor

mds1 commented Apr 11, 2025

Reassigned this one to @smartcontracts since he reviewed the original FMA

@op-aaron op-aaron assigned agusduha and unassigned smartcontracts Apr 14, 2025
@op-aaron
Copy link
Contributor

Approved and merged so closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed/Done
Status: Done
Development

No branches or pull requests

6 participants