Skip to content

Commit 8032b63

Browse files
s1naholimangballet
authored
core/tracing: add verkle gas change reasons to changelog (#30444)
Add changes from #30409 and #29338 to changelog. --------- Co-authored-by: Martin HS <[email protected]> Co-authored-by: Guillaume Ballet <[email protected]>
1 parent 8dd2962 commit 8032b63

File tree

2 files changed

+24
-5
lines changed

2 files changed

+24
-5
lines changed

core/tracing/CHANGELOG.md

+20-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,24 @@
22

33
All notable changes to the tracing interface will be documented in this file.
44

5+
## [Unreleased]
6+
7+
### Modified types
8+
9+
- `GasChangeReason` has been extended with the following reasons which will be enabled only post-Verkle. There shouldn't be any gas changes with those reasons prior to the fork.
10+
- `GasChangeWitnessContractCollisionCheck` flags the event of adding to the witness when checking for contract address collision.
11+
12+
## [v1.14.4]
13+
14+
This release contained only minor extensions to the tracing interface.
15+
16+
### Modified types
17+
18+
- `GasChangeReason` has been extended with the following reasons that will only be active post-Verkle.
19+
- `GasChangeWitnessContractInit` flags the event of adding to the witness during the contract creation initialization step.
20+
- `GasChangeWitnessContractCreation` flags the event of adding to the witness during the contract creation finalization step.
21+
- `GasChangeWitnessCodeChunk` flags the event of adding one or more contract code chunks to the witness.
22+
523
## [v1.14.3]
624

725
There have been minor backwards-compatible changes to the tracing interface to explicitly mark the execution of **system** contracts. As of now the only system call updates the parent beacon block root as per [EIP-4788](https://eips.ethereum.org/EIPS/eip-4788). Other system calls are being considered for the future hardfork.
@@ -75,6 +93,7 @@ The hooks `CaptureStart` and `CaptureEnd` have been removed. These hooks signale
7593
- `CaptureState` -> `OnOpcode(pc uint64, op byte, gas, cost uint64, scope tracing.OpContext, rData []byte, depth int, err error)`. `op` is of type `byte` which can be cast to `vm.OpCode` when necessary. A `*vm.ScopeContext` is not passed anymore. It is replaced by `tracing.OpContext` which offers access to the memory, stack and current contract.
7694
- `CaptureFault` -> `OnFault(pc uint64, op byte, gas, cost uint64, scope tracing.OpContext, depth int, err error)`. Similar to above.
7795

78-
[unreleased]: https://github.com/ethereum/go-ethereum/compare/v1.14.0...master
96+
[unreleased]: https://github.com/ethereum/go-ethereum/compare/v1.14.8...master
7997
[v1.14.0]: https://github.com/ethereum/go-ethereum/releases/tag/v1.14.0
8098
[v1.14.3]: https://github.com/ethereum/go-ethereum/releases/tag/v1.14.3
99+
[v1.14.4]: https://github.com/ethereum/go-ethereum/releases/tag/v1.14.4

core/tracing/hooks.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -300,13 +300,13 @@ const (
300300
GasChangeCallStorageColdAccess GasChangeReason = 13
301301
// GasChangeCallFailedExecution is the burning of the remaining gas when the execution failed without a revert.
302302
GasChangeCallFailedExecution GasChangeReason = 14
303-
// GasChangeWitnessContractInit flags the event of adding to the witness during the contract creation initialization step
303+
// GasChangeWitnessContractInit flags the event of adding to the witness during the contract creation initialization step.
304304
GasChangeWitnessContractInit GasChangeReason = 15
305-
// GasChangeWitnessContractCreation flags the event of adding to the witness during the contract creation finalization step
305+
// GasChangeWitnessContractCreation flags the event of adding to the witness during the contract creation finalization step.
306306
GasChangeWitnessContractCreation GasChangeReason = 16
307-
// GasChangeWitnessCodeChunk flags the event of adding one or more contract code chunks to the witness
307+
// GasChangeWitnessCodeChunk flags the event of adding one or more contract code chunks to the witness.
308308
GasChangeWitnessCodeChunk GasChangeReason = 17
309-
// GasChangeWitnessContractCollisionCheck flags the event of adding to the witness when checking for contract address collision
309+
// GasChangeWitnessContractCollisionCheck flags the event of adding to the witness when checking for contract address collision.
310310
GasChangeWitnessContractCollisionCheck GasChangeReason = 18
311311

312312
// GasChangeIgnored is a special value that can be used to indicate that the gas change should be ignored as

0 commit comments

Comments
 (0)