Skip to content

Commit a5b1b9d

Browse files
committed
eth: nested declaration of discovery iterators
No functional change, just easier to read. Signed-off-by: Csaba Kiraly <[email protected]>
1 parent 6a6189b commit a5b1b9d

File tree

1 file changed

+14
-10
lines changed

1 file changed

+14
-10
lines changed

eth/backend.go

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -521,12 +521,14 @@ func (s *Ethereum) setupDiscovery() error {
521521
if s.p2pServer.DiscoveryV4() != nil {
522522
fairmix := enode.NewFairMix(0)
523523
for i := 0; i < discoveryParallelLookups; i++ {
524-
asyncFilter := s.p2pServer.DiscoveryV4().RequestENR
525-
filter := eth.NewNodeFilter(s.blockchain)
526-
iter := enode.AsyncFilter(
527-
enode.NewBufferIter(s.p2pServer.DiscoveryV4().RandomNodes(), discoveryPrefetchBuffer),
528-
asyncFilter, maxParallelENRRequests)
529-
iter = enode.Filter(iter, filter)
524+
iter := enode.Filter(
525+
enode.AsyncFilter(
526+
enode.NewBufferIter(
527+
s.p2pServer.DiscoveryV4().RandomNodes(),
528+
discoveryPrefetchBuffer,
529+
), s.p2pServer.DiscoveryV4().RequestENR, maxParallelENRRequests,
530+
), eth.NewNodeFilter(s.blockchain),
531+
)
530532
fairmix.AddSource(iter, fmt.Sprintf("DiscoveryV4-%d", i))
531533
}
532534
s.discmix.AddSource(fairmix, "DiscoveryV4")
@@ -536,10 +538,12 @@ func (s *Ethereum) setupDiscovery() error {
536538
if s.p2pServer.DiscoveryV5() != nil {
537539
fairmix := enode.NewFairMix(0)
538540
for i := 0; i < discoveryParallelLookups; i++ {
539-
iter := enode.NewBufferIter(s.p2pServer.DiscoveryV5().RandomNodes(), discoveryPrefetchBuffer)
540-
filter := eth.NewNodeFilter(s.blockchain)
541-
filterIter := enode.Filter(iter, filter)
542-
fairmix.AddSource(filterIter, fmt.Sprintf("DiscoveryV5-%d", i))
541+
iter := enode.Filter(
542+
enode.NewBufferIter(
543+
s.p2pServer.DiscoveryV5().RandomNodes(), discoveryPrefetchBuffer,
544+
), eth.NewNodeFilter(s.blockchain),
545+
)
546+
fairmix.AddSource(iter, fmt.Sprintf("DiscoveryV5-%d", i))
543547
}
544548
s.discmix.AddSource(fairmix, "DiscoveryV5")
545549
}

0 commit comments

Comments
 (0)