eth/gasprice: fix percentile validation in eth_feeHistory (#28954)

fjl · web-flow · commit ae3b7a0b6592 · 2024-02-08T13:34:38.000+01:00
diff --git a/eth/gasprice/feehistory.go b/eth/gasprice/feehistory.go
@@ -227,8 +227,8 @@ func (oracle *Oracle) FeeHistory(ctx context.Context, blocks uint64, unresolvedL
 		if p < 0 || p > 100 {
 			return common.Big0, nil, nil, nil, fmt.Errorf("%w: %f", errInvalidPercentile, p)
 		}
-		if i > 0 && p < rewardPercentiles[i-1] {
-			return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f > #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)
+		if i > 0 && p <= rewardPercentiles[i-1] {
+			return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f >= #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)
 		}
 	}
 	var (

Original file line number	Diff line number	Diff line change
`@@ -227,8 +227,8 @@ func (oracle *Oracle) FeeHistory(ctx context.Context, blocks uint64, unresolvedL`
`227`	`227`	`if p < 0 \|\| p > 100 {`
`228`	`228`	`return common.Big0, nil, nil, nil, fmt.Errorf("%w: %f", errInvalidPercentile, p)`
`229`	`229`	`}`
`230`		`- if i > 0 && p < rewardPercentiles[i-1] {`
`231`		`- return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f > #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)`
	`230`	`+ if i > 0 && p <= rewardPercentiles[i-1] {`
	`231`	`+ return common.Big0, nil, nil, nil, fmt.Errorf("%w: #%d:%f >= #%d:%f", errInvalidPercentile, i-1, rewardPercentiles[i-1], i, p)`
`232`	`232`	`}`
`233`	`233`	`}`
`234`	`234`	`var (`