Skip to content

Commit be1b85d

Browse files
🐛 Fix tab-item label with nested syntax (#135)
Co-authored-by: Chris Sewell <[email protected]>
1 parent 89aaa26 commit be1b85d

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

docs/snippets/myst/tab-options.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
::::{tab-set}
22
:class: class-set
33

4-
:::{tab-item} Label
4+
:::{tab-item} **Label**
55
:name: target
66
:selected:
77
:class-container: class-container

docs/snippets/rst/tab-options.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
.. tab-set::
22
:class: class-set
33

4-
.. tab-item:: Label
4+
.. tab-item:: **Label**
55
:name: target
66
:selected:
77
:class-container: class-container

sphinx_design/tabs.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -99,6 +99,7 @@ def run(self) -> list[nodes.Node]:
9999
textnodes, _ = self.state.inline_text(self.arguments[0], self.lineno)
100100
tab_label = nodes.rubric(
101101
self.arguments[0],
102+
"",
102103
*textnodes,
103104
classes=["sd-tab-label", *self.options.get("class-label", [])],
104105
)
@@ -255,6 +256,7 @@ def run(self) -> None:
255256

256257
# create: <label for="id">...</label>
257258
label_node = sd_tab_label(
259+
"",
258260
"",
259261
*tab_label.children,
260262
input_id=tab_item_identity,

tests/test_snippets/snippet_post_tab-options.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<container classes="sd-tab-set class-set" design_component="tab-set" is_div="True">
66
<sd_tab_input checked="True" id="sd-tab-item-0" set_id="sd-tab-set-0" type="radio">
77
<sd_tab_label classes="sd-tab-label class-label" ids="target" input_id="sd-tab-item-0">
8-
Label
8+
<strong>
9+
Label
910
<container classes="sd-tab-content class-content" design_component="tab-content" is_div="True">
1011
<paragraph>
1112
Content

tests/test_snippets/snippet_pre_tab-options.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,8 @@
55
<container classes="sd-tab-set class-set" design_component="tab-set" is_div="True">
66
<container classes="sd-tab-item class-container" design_component="tab-item" is_div="True" selected="True">
77
<rubric classes="sd-tab-label class-label" ids="target" names="target">
8-
Label
8+
<strong>
9+
Label
910
<container classes="sd-tab-content class-content" design_component="tab-content" is_div="True">
1011
<paragraph>
1112
Content

0 commit comments

Comments
 (0)