Skip to content

Commit e1f0b67

Browse files
refactor(phone-number): prefer cond to case for readability
1 parent a488fea commit e1f0b67

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

exercises/practice/phone-number/.meta/example.ex

+6-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,12 @@ defmodule PhoneNumber do
3636
end
3737

3838
defp validate_length(number) do
39-
case String.length(number) do
40-
invalid when invalid < 10 -> {:error, "must not be fewer than 10 digits"}
41-
invalid when invalid > 11 -> {:error, "must not be greater than 11 digits"}
42-
_valid -> {:ok, number}
39+
length = String.length(number)
40+
41+
cond do
42+
length < 10 -> {:error, "must not be fewer than 10 digits"}
43+
length > 11 -> {:error, "must not be greater than 11 digits"}
44+
true -> {:ok, number}
4345
end
4446
end
4547

0 commit comments

Comments
 (0)