Skip to content

dominoes missing more general test cases #2196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zeltbrennt opened this issue Nov 6, 2022 · 2 comments
Closed

dominoes missing more general test cases #2196

zeltbrennt opened this issue Nov 6, 2022 · 2 comments
Labels

Comments

@zeltbrennt
Copy link

I managed to complete the exercise with a sollution that should not be marked as correct. In the cantBeChainedTest() all dominoes can be chained, only the chain itself is not valid. If one finds an algorithm that accounts only for that, but never actually checks if the list of dominoes can build any chain, then all tests might pass, but the sollution is not correct.

My sollution passed every test, but would try for ever to find a chain here:

Domino[] dominoesArray = {new Domino(1, 2), new Domino(2, 4), new Domino(4, 2), new Domino(4, 3)};
@andrerfcsantos
Copy link
Member

Hi @zeltbrennt,

Tests for practice exercises are taken from problem-specifications. It might be the case that there is a test in canonical-data that already catches the case you are talking about? If that's the case, feel free to submit a PR updating the tests for this exercise so they match the tests in canonical data.

If the test that catches your faulty solution is not in canonical data, feel free to submit a PR in problem-specifications adding a new test, and then we can bring it to the Java track after its approved there.

@sanderploegsma
Copy link
Contributor

Closing this due to inactivity.

@sanderploegsma sanderploegsma closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants