Skip to content

Commit dc02b0d

Browse files
committed
Added options support to res.clearCookie()
1 parent e0bc571 commit dc02b0d

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

Diff for: docs/guide.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -894,7 +894,7 @@ To parse incoming _Cookie_ headers, use the _cookieParser_ middleware, which pro
894894
// use req.cookies.rememberme
895895
});
896896

897-
### res.clearCookie(name)
897+
### res.clearCookie(name[, options])
898898

899899
Clear cookie _name_ by setting "expires" far in the past.
900900

Diff for: lib/response.js

+6-2
Original file line numberDiff line numberDiff line change
@@ -246,11 +246,15 @@ res.header = function(name, val){
246246
* Clear cookie `name`.
247247
*
248248
* @param {String} name
249+
* @param {Object} options
249250
* @api public
250251
*/
251252

252-
res.clearCookie = function(name){
253-
this.cookie(name, '', { expires: new Date(1) });
253+
res.clearCookie = function(name, options){
254+
var opts = { expires: new Date(1) };
255+
this.cookie(name, '', options
256+
? utils.merge(options, opts)
257+
: opts);
254258
};
255259

256260
/**

Diff for: test/response.test.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -570,15 +570,15 @@ module.exports = {
570570
var app = express.createServer();
571571

572572
app.get('/', function(req, res){
573-
res.clearCookie('rememberme');
573+
res.clearCookie('rememberme', { path: '/foo' });
574574
res.redirect('/');
575575
});
576576

577577
assert.response(app,
578578
{ url: '/' },
579579
function(res){
580580
res.headers['set-cookie']
581-
.should.eql(['rememberme=; expires=Thu, 01 Jan 1970 00:00:00 GMT']);
581+
.should.eql(['rememberme=; path=/foo; expires=Thu, 01 Jan 1970 00:00:00 GMT']);
582582
});
583583
},
584584

0 commit comments

Comments
 (0)