Fix to correctly show binding name in bindings list

Fixes openshift#2145

Author: jeff-phillips-18

app/scripts/directives/overview/serviceBindings.js

@@ -5,6 +5,7 @@ angular.module('openshiftConsole').component('overviewServiceBindings', {
   bindings: {
     sectionTitle: '@',
     namespace: '<',
+    refApiObject: '<',
     bindings: '<',
     bindableServiceInstances: '<',
     serviceClasses: '<',

app/scripts/directives/serviceBinding.js

@@ -19,11 +19,14 @@
 
   function ServiceBinding() {
     var ctrl = this;
+
     var updateServiceClass = function() {
-      var instanceName = _.get(ctrl.binding, 'spec.instanceRef.name');
-      var instance = _.get(ctrl.serviceInstances, [instanceName]);
-      var serviceClassName = _.get(instance, 'spec.serviceClassName');
-      ctrl.serviceClass = _.get(ctrl.serviceClasses, [serviceClassName]);
+      if (_.get(ctrl.refApiObject, 'kind') !== 'ServiceInstance') {
+        var instanceName = _.get(ctrl.binding, 'spec.instanceRef.name');
+        var instance = _.get(ctrl.serviceInstances, [instanceName]);
+        var serviceClassName = _.get(instance, 'spec.serviceClassName');
+        ctrl.serviceClass = _.get(ctrl.serviceClasses, [serviceClassName]);
+      }
     };
 
     this.$onChanges = function(changes) {

app/views/directives/_service-binding.html

@@ -6,18 +6,13 @@ <h3>
         <div class="component-label">
           Secret
         </div>
-        <span ng-if="$ctrl.serviceClass">
-          <span ng-if="$ctrl.refApiObject.kind !== 'ServiceInstance'">
+        {{$ctrl.binding.metadata.name}}
+        <span ng-if="$ctrl.refApiObject.kind !== 'ServiceInstance'">
+          <small ng-if="$ctrl.serviceClass">
             {{$ctrl.serviceClass.externalMetadata.displayName || $ctrl.serviceClass.metadata.name}}
-          </span>
-          <span ng-if="$ctrl.refApiObject.kind === 'ServiceInstance'">
-            {{$ctrl.binding.spec.secretName}}
-          </span>
+          </small>
+          <small>{{$ctrl.binding.spec.instanceRef.name}}</small>
         </span>
-        <span ng-if="!$ctrl.serviceClass">
-          {{$ctrl.binding.spec.instanceRef.name}}
-        </span>
-        <small ng-if="$ctrl.serviceClass">{{$ctrl.binding.spec.instanceRef.name}}</small>
         <small>created <span am-time-ago="$ctrl.binding.metadata.creationTimestamp"></span></small>
       </h3>
     </div>

app/views/overview/_list-row-expanded.html

@@ -179,6 +179,7 @@ <h4 class="h5" translate>Average Usage <small>Last 15 Minutes</small></h4>
             <uib-tab-heading translate>Bindings</uib-tab-heading>
             <overview-service-bindings
               section-title="Service Bindings"
+              ref-api-object="row.apiObject"
               namespace="row.apiObject.metadata.namespace"
               bindings="row.bindings"
               bindable-service-instances="row.state.bindableServiceInstances"
@@ -216,6 +217,7 @@ <h4 class="h5" translate>Average Usage <small>Last 15 Minutes</small></h4>
       <overview-service-bindings
         section-title="Service Bindings"
         ng-if="row.showBindings && (row.bindings | size)"
+        ref-api-object="row.apiObject"
         namespace="row.apiObject.metadata.namespace"
         bindings="row.bindings"
         bindable-service-instances="row.state.bindableServiceInstances"

app/views/overview/_service-bindings.html

@@ -4,6 +4,7 @@
     ng-repeat="binding in $ctrl.bindings track by (binding | uid)"
     is-overview="true"
     namespace="$ctrl.namespace"
+    ref-api-object="$ctrl.refApiObject"
     binding="binding"
     service-classes="$ctrl.serviceClasses"
     service-instances="$ctrl.serviceInstances"

app/views/overview/_service-instance-row.html

@@ -166,6 +166,7 @@ <h3>
           <overview-service-bindings
             ng-if="row.isBindable || row.bindings"
             section-title="Bindings"
+            ref-api-object="row.apiObject"
             namespace="row.apiObject.metadata.namespace"
             bindings="row.bindings"
             bindable-service-instances="row.state.bindableServiceInstances"

dist/scripts/scripts.js

@@ -26387,8 +26387,10 @@ controller: [ "APIService", "AuthorizationService", "DataService", "Logger", "Se
 angular.module("openshiftConsole").component("serviceBinding", {
 controller: [ function() {
 var e = this, t = function() {
+if ("ServiceInstance" !== _.get(e.refApiObject, "kind")) {
 var t = _.get(e.binding, "spec.instanceRef.name"), n = _.get(e.serviceInstances, [ t ]), a = _.get(n, "spec.serviceClassName");
 e.serviceClass = _.get(e.serviceClasses, [ a ]);
+}
 };
 this.$onChanges = function(e) {
 (e.binding || e.serviceInstances || e.serviceClasses) && t();
@@ -27124,7 +27126,11 @@ refApiObject: "<",
 sectionTitle: "@",
 >>>>>>> Updates to service instance page, show failed bindings
 namespace: "<",
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
 >>>>>>> Add bindings list to resource pages
+=======
+refApiObject: "<",
+>>>>>>> Fix to correctly show binding name in bindings list
 bindings: "<",
 bindableServiceInstances: "<",
 serviceClasses: "<",

dist/scripts/templates.js

@@ -6489,19 +6489,18 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<div class=\"component-label\">\n" +
     "Secret\n" +
     "</div>\n" +
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
 >>>>>>> Updates to service instance page, show failed bindings
     "<span ng-if=\"$ctrl.serviceClass\">\n" +
+=======
+    "{{$ctrl.binding.metadata.name}}\n" +
+>>>>>>> Fix to correctly show binding name in bindings list
     "<span ng-if=\"$ctrl.refApiObject.kind !== 'ServiceInstance'\">\n" +
+    "<small ng-if=\"$ctrl.serviceClass\">\n" +
     "{{$ctrl.serviceClass.externalMetadata.displayName || $ctrl.serviceClass.metadata.name}}\n" +
+    "</small>\n" +
+    "<small>{{$ctrl.binding.spec.instanceRef.name}}</small>\n" +
     "</span>\n" +
-    "<span ng-if=\"$ctrl.refApiObject.kind === 'ServiceInstance'\">\n" +
-    "{{$ctrl.binding.spec.secretName}}\n" +
-    "</span>\n" +
-    "</span>\n" +
-    "<span ng-if=\"!$ctrl.serviceClass\">\n" +
-    "{{$ctrl.binding.spec.instanceRef.name}}\n" +
-    "</span>\n" +
-    "<small ng-if=\"$ctrl.serviceClass\">{{$ctrl.binding.spec.instanceRef.name}}</small>\n" +
     "<small>created <span am-time-ago=\"$ctrl.binding.metadata.creationTimestamp\"></span></small>\n" +
     "</h3>\n" +
     "</div>\n" +
@@ -14280,12 +14279,16 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<overview-service-bindings section-title=\"Service Bindings\" ref-api-object=\"row.apiObject\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
 =======
     "<uib-tab-heading>Bindings</uib-tab-heading>\n" +
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
 <<<<<<< 564bfad6c6a2a2e087a95a77d3e86fc5e258bfdc
     "<overview-service-bindings namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
 >>>>>>> Add bindings list to resource pages
 =======
     "<overview-service-bindings section-title=\"Service Bindings\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
 >>>>>>> Updates to service instance page, show failed bindings
+=======
+    "<overview-service-bindings section-title=\"Service Bindings\" ref-api-object=\"row.apiObject\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
+>>>>>>> Fix to correctly show binding name in bindings list
     "</overview-service-bindings>\n" +
     "</uib-tab>\n" +
     "</uib-tabset>\n" +
@@ -14301,6 +14304,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "\n" +
     "<overview-builds build-configs=\"row.buildConfigs\" recent-builds-by-build-config=\"row.state.recentBuildsByBuildConfig\" context=\"row.state.context\" hide-log=\"row.state.limitWatches\">\n" +
     "</overview-builds>\n" +
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
 <<<<<<< 564bfad6c6a2a2e087a95a77d3e86fc5e258bfdc
 <<<<<<< 952b26bc3acaa89a51e4aad5f965e515d3b007ae
     "<overview-service-bindings section-title=\"Service Bindings\" ng-if=\"row.showBindings && (row.bindings | size)\" ref-api-object=\"row.apiObject\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
@@ -14310,6 +14314,9 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
 =======
     "<overview-service-bindings section-title=\"Service Bindings\" ng-if=\"row.showBindings && (row.bindings | size)\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
 >>>>>>> Updates to service instance page, show failed bindings
+=======
+    "<overview-service-bindings section-title=\"Service Bindings\" ng-if=\"row.showBindings && (row.bindings | size)\" ref-api-object=\"row.apiObject\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" service-instances=\"row.state.serviceInstances\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
+>>>>>>> Fix to correctly show binding name in bindings list
     "</overview-service-bindings>\n" +
     "</div>\n" +
     "</div>\n" +
@@ -14555,8 +14562,12 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" namespace=\"$ctrl.namespace\" binding=\"binding\" service-classes=\"$ctrl.serviceClasses\" service-instances=\"$ctrl.serviceInstances\" secrets=\"$ctrl.secrets\">\n" +
 =======
     "<div class=\"section-title hidden-xs\">{{$ctrl.sectionTitle}}</div>\n" +
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
     "<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" is-overview=\"true\" namespace=\"$ctrl.namespace\" binding=\"binding\" service-classes=\"$ctrl.serviceClasses\" service-instances=\"$ctrl.serviceInstances\" secrets=\"$ctrl.secrets\">\n" +
 >>>>>>> Updates to service instance page, show failed bindings
+=======
+    "<service-binding ng-repeat=\"binding in $ctrl.bindings track by (binding | uid)\" is-overview=\"true\" namespace=\"$ctrl.namespace\" ref-api-object=\"$ctrl.refApiObject\" binding=\"binding\" service-classes=\"$ctrl.serviceClasses\" service-instances=\"$ctrl.serviceInstances\" secrets=\"$ctrl.secrets\">\n" +
+>>>>>>> Fix to correctly show binding name in bindings list
     "</service-binding>\n" +
     "<div ng-if=\"($ctrl.bindableServiceInstances | size) && ({resource: 'serviceinstancecredentials', group: 'servicecatalog.k8s.io'} | canI : 'create')\">\n" +
     "<a href=\"\" ng-click=\"$ctrl.createBinding()\" role=\"button\">\n" +
@@ -14845,6 +14856,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "<a ng-if=\"row.serviceClass.spec.externalMetadata.documentationUrl\" ng-href=\"{{row.serviceClass.spec.externalMetadata.documentationUrl}}\" target=\"_blank\" class=\"learn-more-link\"><translate>View Documentation</translate> <i class=\"fa fa-external-link\" aria-hidden=\"true\"></i></a>\n" +
     "<a ng-if=\"row.serviceClass.spec.externalMetadata.supportUrl\" ng-href=\"{{row.serviceClass.spec.externalMetadata.supportUrl}}\" target=\"_blank\" class=\"learn-more-link\"><translate>Get Support</translate> <i class=\"fa fa-external-link\" aria-hidden=\"true\"></i></a>\n" +
     "</div>\n" +
+<<<<<<< 6c8edd544179ba4c13819fe643c11051e3e612cb
     "</div>\n" +
 <<<<<<< 5985737c08b962a908ac7e4cb2134962ae561acf
 =======
@@ -14860,6 +14872,9 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
     "</div>\n" +
 =======
     "<overview-service-bindings ng-if=\"row.isBindable || row.bindings\" section-title=\"Bindings\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
+=======
+    "<overview-service-bindings ng-if=\"row.isBindable || row.bindings\" section-title=\"Bindings\" ref-api-object=\"row.apiObject\" namespace=\"row.apiObject.metadata.namespace\" bindings=\"row.bindings\" bindable-service-instances=\"row.state.bindableServiceInstances\" service-classes=\"row.state.serviceClasses\" create-binding=\"row.showOverlayPanel('bindService', {target: row.apiObject})\">\n" +
+>>>>>>> Fix to correctly show binding name in bindings list
     "</overview-service-bindings>\n" +
 >>>>>>> Updates to service instance page, show failed bindings
     "</div>\n" +