Skip to content

Commit e71fd4c

Browse files
benjaminapetersenf0x11
authored andcommitted
Fix issue 2272: Show hidden roles checkbox isnt functioning properly
1 parent a8e0cf5 commit e71fd4c

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

app/views/membership.html

+5-1
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,11 @@ <h3 translate>
281281
<div class="col-add-role" row>
282282
<div class="checkbox">
283283
<label>
284-
<input type="checkbox" class="toggle-hidden" ng-click="showAllRoles($event)">
284+
<input
285+
type="checkbox"
286+
class="toggle-hidden"
287+
ng-click="toggleRoles($event)"
288+
ng-checked="toggle.roles">
285289
Show hidden roles</label>&nbsp;<a href=""
286290
class="action-inline"
287291
data-toggle="popover"

dist/scripts/scripts.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -10474,7 +10474,7 @@ toggle: {
1047410474
roles: !1
1047510475
},
1047610476
filteredRoles: n,
10477-
showAllRoles: function() {
10477+
toggleRoles: function() {
1047810478
a.toggle.roles = !a.toggle.roles, a.toggle.roles ? a.filteredRoles = t : (a.filteredRoles = n, r(a.newBinding.role, n) || (a.newBinding.role = null));
1047910479
>>>>>>> Bump grunt-contrib-uglify to 3.0.1
1048010480
}

dist/scripts/templates.js

+4
Original file line numberDiff line numberDiff line change
@@ -13210,7 +13210,11 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1321013210
"<div class=\"checkbox\">\n" +
1321113211
"<label>\n" +
1321213212
"<input type=\"checkbox\" class=\"toggle-hidden\" ng-click=\"toggleRoles($event)\" ng-checked=\"toggle.roles\">\n" +
13213+
<<<<<<< 13ff190e1f8d3b6f15c4271dc3b6896bca567f1f
1321313214
"<translate>Show hidden roles</translate></label>&nbsp;<a href=\"\" class=\"action-inline\" data-toggle=\"popover\" data-trigger=\"hover focus\" data-content=\"{{'System roles are hidden by default and do not typically need to be managed.'|translate}}\"><i class=\"pficon pficon-help\"></i></a>\n" +
13215+
=======
13216+
"Show hidden roles</label>&nbsp;<a href=\"\" class=\"action-inline\" data-toggle=\"popover\" data-trigger=\"hover focus\" data-content=\"System roles are hidden by default and do not typically need to be managed.\"><i class=\"pficon pficon-help\"></i></a>\n" +
13217+
>>>>>>> Fix issue 2272: Show hidden roles checkbox isnt functioning properly
1321413218
"</div>\n" +
1321513219
"</div>\n" +
1321613220
"</div>\n" +

0 commit comments

Comments
 (0)