We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi,
I have noticed that JSDoc comments for parameters are not actual JSDoc comments. (Line[104, 108, 114])
(Line[104, 108, 114])
For example:
openapi-codegen/examples/frontend/src/github/githubSchemas.ts
Lines 100 to 118 in 086519e
they should start with /** not /*
/**
/*
I noticed this while I was testing https://github.com/fabien0102/ts-to-zod
Even in the tests, JSDoc comments start with /* [Line 145]
openapi-codegen/plugins/typescript/src/generators/generateSchemaTypes.test.ts
Lines 136 to 149 in 086519e
For a reference from https://github.com/fabien0102/zod-schema-from-stripe
https://github.com/fabien0102/zod-schema-from-stripe/blob/b3a3156f7ca54d4dc411dfa826dfc2d8cd4e5a0c/src/stripe/stripeSchemas.ts#L150-L156
Because of this fabien0102/ts-to-zod can't generate correct zod schemas. It is ignoring maxLength, etc.
The text was updated successfully, but these errors were encountered:
Looks like this is related to this TypeScript issue.
microsoft/TypeScript#17146
I can come up with a quick fix until this issue is solved. If this approach is acceptable.
ts.addSyntheticLeadingComment( node, ts.SyntaxKind.MultiLineCommentTrivia, "*" + jsDocString, // https://github.com/microsoft/TypeScript/issues/17146 true );
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
Hi,
I have noticed that JSDoc comments for parameters are not actual JSDoc comments.
(Line[104, 108, 114])
For example:
openapi-codegen/examples/frontend/src/github/githubSchemas.ts
Lines 100 to 118 in 086519e
they should start with
/**
not/*
I noticed this while I was testing https://github.com/fabien0102/ts-to-zod
Even in the tests, JSDoc comments start with
/*
[Line 145]openapi-codegen/plugins/typescript/src/generators/generateSchemaTypes.test.ts
Lines 136 to 149 in 086519e
For a reference from https://github.com/fabien0102/zod-schema-from-stripe
https://github.com/fabien0102/zod-schema-from-stripe/blob/b3a3156f7ca54d4dc411dfa826dfc2d8cd4e5a0c/src/stripe/stripeSchemas.ts#L150-L156
Because of this fabien0102/ts-to-zod can't generate correct zod schemas. It is ignoring maxLength, etc.
The text was updated successfully, but these errors were encountered: