Skip to content

Commit 80f6b5c

Browse files
authored
fix: Kube API Test startup fails on readiness SSL check (6987)
fix: Kuber API Test startup fails on readyness SSL check In rare curcumstaces this it might occur that the readiness problem communcation fails on SSL error. Signed-off-by: Attila Mészáros <[email protected]> --- changelog Signed-off-by: Attila Mészáros <[email protected]>
1 parent c7d4669 commit 80f6b5c

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
* Fix #6930: Add support for Boolean enums in the java-generator
1212
* Fix #6941: HasMetadata.getApiVersion no slash when empty group
1313
* Fix #6829: Mixed-case enums are properly supported by the java-generator
14+
* FIX #6987: Kube API Test startup fails on readiness SSL check
1415

1516
#### Improvements
1617
* Fix #6863: ensuring SerialExecutor does not throw RejectedExecutionException to prevent unnecessary error logs

junit/kube-api-test/core/src/main/java/io/fabric8/kubeapitest/process/ProcessReadinessChecker.java

+5-1
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@
4141

4242
import javax.net.ssl.SSLContext;
4343
import javax.net.ssl.SSLEngine;
44+
import javax.net.ssl.SSLException;
4445
import javax.net.ssl.TrustManager;
4546
import javax.net.ssl.X509ExtendedTrustManager;
4647

@@ -123,7 +124,10 @@ private boolean ready(HttpClient client, HttpRequest request, String processName
123124
response.statusCode(), processName,
124125
port);
125126
return response.statusCode() == 200;
126-
} catch (ConnectException e) {
127+
// It has been reported that in rare circumstances this call might
128+
// result in a javax.net.ssl.SSLException: Unrecognized SSL message
129+
// in that case we still want to retry, assuming this error goes away.
130+
} catch (ConnectException | SSLException e) {
127131
// still want to retry
128132
log.debug("Cannot connect to the server", e);
129133
return false;

0 commit comments

Comments
 (0)