Skip to content

Commit 46829e3

Browse files
committed
Only change gitignore if we create a flowconfig
1 parent be43c83 commit 46829e3

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

Diff for: packages/react-dev-utils/FlowTypecheckPlugin.js

+10-7
Original file line numberDiff line numberDiff line change
@@ -58,10 +58,10 @@ function writeFileIfDoesNotExist(path, data) {
5858
if (err) {
5959
return reject(err);
6060
}
61-
resolve(data);
61+
resolve(true);
6262
});
6363
} else {
64-
resolve(data);
64+
resolve(false);
6565
}
6666
});
6767
});
@@ -75,7 +75,7 @@ function writeInFileIfNotPresent(path, contentToAssert, contentToAppend) {
7575
if (err) {
7676
return reject(err);
7777
}
78-
resolve(contentToAppend);
78+
resolve(true);
7979
});
8080
} else {
8181
fs.readFile(path, (err, existingContent) => {
@@ -87,10 +87,10 @@ function writeInFileIfNotPresent(path, contentToAssert, contentToAppend) {
8787
if (err) {
8888
return reject(err);
8989
}
90-
resolve(contentToAppend);
90+
resolve(true);
9191
});
9292
} else {
93-
resolve(contentToAppend);
93+
resolve(false);
9494
}
9595
});
9696
}
@@ -126,8 +126,11 @@ function initializeFlow(projectPath, flowconfig, otherFlowTypedDefs) {
126126
)) :
127127
true
128128
),
129-
writeFileIfDoesNotExist(flowconfigPath, flowconfig.join('\n')),
130-
writeInFileIfNotPresent(gitignorePath, 'flow-typed', 'flow-typed'),
129+
writeFileIfDoesNotExist(flowconfigPath, flowconfig.join('\n'))
130+
.then(wroteFlowconfig => wroteFlowconfig ?
131+
writeInFileIfNotPresent(gitignorePath, 'flow-typed', 'flow-typed/npm') :
132+
false
133+
),
131134
execOneTime(
132135
flowTypedPath,
133136
['install', '--overwrite', '--flowVersion=' + localVersion],

0 commit comments

Comments
 (0)