Skip to content

Commit 581c453

Browse files
Jack ZhaoTimer
Jack Zhao
authored andcommitted
Scope hoisting in webpack 4 (#4504)
1 parent 61c864c commit 581c453

File tree

3 files changed

+4
-6
lines changed

3 files changed

+4
-6
lines changed

packages/react-scripts/config/webpack.config.prod.js

-2
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,6 @@ module.exports = {
115115
.replace(/\\/g, '/'),
116116
},
117117
optimization: {
118-
// webpack-manifest-plugin currently does not play well with ConcatenatedModule
119-
concatenateModules: false,
120118
minimizer: [
121119
new UglifyJsPlugin({
122120
uglifyOptions: {

packages/react-scripts/fixtures/kitchensink/.template.dependencies.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{
22
"dependencies": {
3-
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.36",
4-
"@babel/polyfill": "7.0.0-beta.36",
5-
"@babel/register": "7.0.0-beta.36",
3+
"@babel/plugin-transform-modules-commonjs": "7.0.0-beta.46",
4+
"@babel/polyfill": "7.0.0-beta.46",
5+
"@babel/register": "7.0.0-beta.46",
66
"bootstrap": "4.1.0",
77
"chai": "3.5.0",
88
"jsdom": "9.8.3",

packages/react-scripts/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"url-loader": "1.0.1",
6969
"webpack": "4.8.3",
7070
"webpack-dev-server": "3.1.4",
71-
"webpack-manifest-plugin": "2.0.2",
71+
"webpack-manifest-plugin": "2.0.3",
7272
"whatwg-fetch": "2.0.4"
7373
},
7474
"devDependencies": {

0 commit comments

Comments
 (0)