Deduplicate identical errors

gaearon · gaearon · commit 645dc42a18da · 2017-08-27T18:44:36.000-07:00
diff --git a/packages/react-error-overlay/src/index.js b/packages/react-error-overlay/src/index.js
@@ -59,6 +59,13 @@ export function startReportingRuntimeErrors(options: RuntimeReportingOptions) {
 }
 
 function handleRuntimeError(errorRecord) {
+  if (
+    currentRuntimeErrorRecords.some(({ error }) => error === errorRecord.error)
+  ) {
+    // Deduplicate identical errors.
+    // This fixes https://github.com/facebookincubator/create-react-app/issues/3011.
+    return;
+  }
   currentRuntimeErrorRecords = currentRuntimeErrorRecords.concat([errorRecord]);
   update();
 }

Original file line number	Diff line number	Diff line change
`@@ -59,6 +59,13 @@ export function startReportingRuntimeErrors(options: RuntimeReportingOptions) {`
`59`	`59`	`}`
`60`	`60`
`61`	`61`	`function handleRuntimeError(errorRecord) {`
	`62`	`+ if (`
	`63`	`+ currentRuntimeErrorRecords.some(({ error }) => error === errorRecord.error)`
	`64`	`+ ) {`
	`65`	`+ // Deduplicate identical errors.`
	`66`	`+ // This fixes https://github.com/facebookincubator/create-react-app/issues/3011.`
	`67`	`+ return;`
	`68`	`+ }`
`62`	`69`	`currentRuntimeErrorRecords = currentRuntimeErrorRecords.concat([errorRecord]);`
`63`	`70`	`update();`
`64`	`71`	`}`