Skip to content

Commit 6bda4b9

Browse files
fsongaearon
authored andcommitted
Remove custom babel-loader cache dir config (#983)
Upgrade `babel-loader` and remove the cache directory configuration that was added in #620. `babel-loader` now uses the `./node_modules/.cache/babel-loader` directory by default, so the custom config is no longer needed.
1 parent 7ce4b6e commit 6bda4b9

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

packages/react-scripts/config/webpack.config.dev.js

+3-7
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
var path = require('path');
1313
var autoprefixer = require('autoprefixer');
1414
var webpack = require('webpack');
15-
var findCacheDir = require('find-cache-dir');
1615
var HtmlWebpackPlugin = require('html-webpack-plugin');
1716
var CaseSensitivePathsPlugin = require('case-sensitive-paths-webpack-plugin');
1817
var InterpolateHtmlPlugin = require('react-dev-utils/InterpolateHtmlPlugin');
@@ -122,12 +121,9 @@ module.exports = {
122121
presets: [require.resolve('babel-preset-react-app')],
123122
// @remove-on-eject-end
124123
// This is a feature of `babel-loader` for webpack (not Babel itself).
125-
// It enables caching results in ./node_modules/.cache/react-scripts/
126-
// directory for faster rebuilds. We use findCacheDir() because of:
127-
// https://github.com/facebookincubator/create-react-app/issues/483
128-
cacheDirectory: findCacheDir({
129-
name: 'react-scripts'
130-
})
124+
// It enables caching results in ./node_modules/.cache/babel-loader/
125+
// directory for faster rebuilds.
126+
cacheDirectory: true
131127
}
132128
},
133129
// "postcss" loader applies autoprefixer to our CSS.

packages/react-scripts/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
"babel-core": "6.17.0",
2828
"babel-eslint": "7.0.0",
2929
"babel-jest": "16.0.0",
30-
"babel-loader": "6.2.5",
30+
"babel-loader": "6.2.7",
3131
"babel-preset-react-app": "^1.0.0",
3232
"case-sensitive-paths-webpack-plugin": "1.1.4",
3333
"chalk": "1.1.3",
@@ -46,7 +46,6 @@
4646
"extract-text-webpack-plugin": "1.0.1",
4747
"file-loader": "0.9.0",
4848
"filesize": "3.3.0",
49-
"find-cache-dir": "0.1.1",
5049
"fs-extra": "0.30.0",
5150
"gzip-size": "3.0.0",
5251
"html-webpack-plugin": "2.24.0",

0 commit comments

Comments
 (0)