Skip to content

Commit e51ea13

Browse files
ianschmitzianschmitz
authored
Temporarily disable Windows in CI (#7773)
1 parent 7fae307 commit e51ea13

File tree

5 files changed

+91
-93
lines changed

5 files changed

+91
-93
lines changed

‎azure-pipelines-test-job.yml

+27-27
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,35 @@ parameters:
66
name: ''
77
testScript: ''
88
configurations:
9-
LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
10-
LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
11-
WindowsNode8: { vmImage: 'vs2017-win2016', nodeVersion: 8.x }
12-
WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
13-
9+
LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
10+
LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
11+
# WindowsNode8: { vmImage: 'vs2017-win2016', nodeVersion: 8.x }
12+
# WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
13+
1414
jobs:
15-
- job: ${{ parameters.name }}
16-
strategy:
17-
matrix:
18-
${{ insert }}: ${{ parameters.configurations }}
19-
pool:
20-
vmImage: $(vmImage)
21-
steps:
22-
- script: |
23-
git config --global core.autocrlf false
24-
git config --global user.name "Create React App"
25-
git config --global user.email "[email protected]"
26-
displayName: 'Initialize Git config'
15+
- job: ${{ parameters.name }}
16+
strategy:
17+
matrix:
18+
${{ insert }}: ${{ parameters.configurations }}
19+
pool:
20+
vmImage: $(vmImage)
21+
steps:
22+
- script: |
23+
git config --global core.autocrlf false
24+
git config --global user.name "Create React App"
25+
git config --global user.email "[email protected]"
26+
displayName: 'Initialize Git config'
2727
28-
- checkout: self
29-
path: create-react-app
28+
- checkout: self
29+
path: create-react-app
3030

31-
- task: NodeTool@0
32-
inputs:
33-
versionSpec: $(nodeVersion)
34-
displayName: 'Install Node.js'
31+
- task: NodeTool@0
32+
inputs:
33+
versionSpec: $(nodeVersion)
34+
displayName: 'Install Node.js'
3535

36-
- script: yarn --frozen-lockfile
37-
displayName: 'Run yarn'
36+
- script: yarn --frozen-lockfile
37+
displayName: 'Run yarn'
3838

39-
- bash: ${{ parameters.testScript }}
40-
displayName: 'Run tests'
39+
- bash: ${{ parameters.testScript }}
40+
displayName: 'Run tests'

‎azure-pipelines.yml

+53-53
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#
44

55
trigger:
6-
- master
6+
- master
77

88
variables:
99
CI: true
@@ -19,60 +19,60 @@ variables:
1919
# Simple test suite
2020
# ******************************************************************************
2121
jobs:
22-
- template: azure-pipelines-test-job.yml
23-
parameters:
24-
name: Simple
25-
testScript: tasks/e2e-simple.sh
22+
- template: azure-pipelines-test-job.yml
23+
parameters:
24+
name: Simple
25+
testScript: tasks/e2e-simple.sh
2626

27-
# ******************************************************************************
28-
# Installs test suite
29-
# ******************************************************************************
30-
- template: azure-pipelines-test-job.yml
31-
parameters:
32-
name: Installs
33-
testScript: tasks/e2e-installs.sh
27+
# ******************************************************************************
28+
# Installs test suite
29+
# ******************************************************************************
30+
- template: azure-pipelines-test-job.yml
31+
parameters:
32+
name: Installs
33+
testScript: tasks/e2e-installs.sh
3434

35-
# ******************************************************************************
36-
# Kitchensink test suite
37-
# ******************************************************************************
38-
- template: azure-pipelines-test-job.yml
39-
parameters:
40-
name: Kitchensink
41-
testScript: tasks/e2e-kitchensink.sh
35+
# ******************************************************************************
36+
# Kitchensink test suite
37+
# ******************************************************************************
38+
- template: azure-pipelines-test-job.yml
39+
parameters:
40+
name: Kitchensink
41+
testScript: tasks/e2e-kitchensink.sh
4242

43-
# ******************************************************************************
44-
# Kitchensink Eject test suite
45-
# ******************************************************************************
46-
- template: azure-pipelines-test-job.yml
47-
parameters:
48-
name: KitchensinkEject
49-
testScript: tasks/e2e-kitchensink-eject.sh
43+
# ******************************************************************************
44+
# Kitchensink Eject test suite
45+
# ******************************************************************************
46+
- template: azure-pipelines-test-job.yml
47+
parameters:
48+
name: KitchensinkEject
49+
testScript: tasks/e2e-kitchensink-eject.sh
5050

51-
# ******************************************************************************
52-
# Behavior test suite
53-
# ******************************************************************************
54-
- template: azure-pipelines-test-job.yml
55-
parameters:
56-
name: Behavior
57-
testScript: tasks/e2e-behavior.sh
58-
configurations:
59-
LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
60-
LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
61-
WindowsNode8: { vmImage: 'vs2017-win2016', nodeVersion: 8.x }
62-
WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
63-
MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
64-
MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
51+
# ******************************************************************************
52+
# Behavior test suite
53+
# ******************************************************************************
54+
- template: azure-pipelines-test-job.yml
55+
parameters:
56+
name: Behavior
57+
testScript: tasks/e2e-behavior.sh
58+
configurations:
59+
LinuxNode8: { vmImage: 'ubuntu-16.04', nodeVersion: 8.x }
60+
LinuxNode10: { vmImage: 'ubuntu-16.04', nodeVersion: 10.x }
61+
# WindowsNode8: { vmImage: 'vs2017-win2016', nodeVersion: 8.x }
62+
# WindowsNode10: { vmImage: 'vs2017-win2016', nodeVersion: 10.x }
63+
MacNode8: { vmImage: 'macOS-10.13', nodeVersion: 8.x }
64+
MacNode10: { vmImage: 'macOS-10.13', nodeVersion: 10.x }
6565

66-
# ******************************************************************************
67-
# Old Node test suite
68-
# ******************************************************************************
69-
- job: OldNode
70-
pool:
71-
vmImage: ubuntu-16.04
72-
steps:
73-
- task: NodeTool@0
74-
inputs:
75-
versionSpec: 6.x
76-
displayName: 'Install Node.js 6.x'
77-
- bash: tasks/e2e-old-node.sh
78-
displayName: 'Run tests'
66+
# ******************************************************************************
67+
# Old Node test suite
68+
# ******************************************************************************
69+
- job: OldNode
70+
pool:
71+
vmImage: ubuntu-16.04
72+
steps:
73+
- task: NodeTool@0
74+
inputs:
75+
versionSpec: 6.x
76+
displayName: 'Install Node.js 6.x'
77+
- bash: tasks/e2e-old-node.sh
78+
displayName: 'Run tests'

‎packages/create-react-app/createReactApp.js

+3-9
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,7 @@ function createApp(
225225
if (!semver.satisfies(process.version, '>=8.10.0')) {
226226
console.log(
227227
chalk.yellow(
228-
`You are using Node ${
229-
process.version
230-
} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
228+
`You are using Node ${process.version} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
231229
`Please update to Node 8.10 or higher for a better, fully supported experience.\n`
232230
)
233231
);
@@ -241,9 +239,7 @@ function createApp(
241239
if (npmInfo.npmVersion) {
242240
console.log(
243241
chalk.yellow(
244-
`You are using npm ${
245-
npmInfo.npmVersion
246-
} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
242+
`You are using npm ${npmInfo.npmVersion} so the project will be bootstrapped with an old unsupported version of tools.\n\n` +
247243
`Please update to npm 5 or higher for a better, fully supported experience.\n`
248244
)
249245
);
@@ -257,9 +253,7 @@ function createApp(
257253
if (yarnInfo.yarnVersion) {
258254
console.log(
259255
chalk.yellow(
260-
`You are using Yarn ${
261-
yarnInfo.yarnVersion
262-
} together with the --use-pnp flag, but Plug'n'Play is only supported starting from the 1.12 release.\n\n` +
256+
`You are using Yarn ${yarnInfo.yarnVersion} together with the --use-pnp flag, but Plug'n'Play is only supported starting from the 1.12 release.\n\n` +
263257
`Please update to Yarn 1.12 or higher for a better, fully supported experience.\n`
264258
)
265259
);

‎packages/react-dev-utils/InlineChunkHtmlPlugin.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@ class InlineChunkHtmlPlugin {
1717
if (tag.tagName !== 'script' || !(tag.attributes && tag.attributes.src)) {
1818
return tag;
1919
}
20-
const scriptName = publicPath ? tag.attributes.src.replace(publicPath, '') : tag.attributes.src;
20+
const scriptName = publicPath
21+
? tag.attributes.src.replace(publicPath, '')
22+
: tag.attributes.src;
2123
if (!this.tests.some(test => scriptName.match(test))) {
2224
return tag;
2325
}

‎packages/react-scripts/scripts/build.js

+5-3
Original file line numberDiff line numberDiff line change
@@ -124,9 +124,11 @@ checkBrowsers(paths.appPath, isInteractive)
124124
err => {
125125
const tscCompileOnError = process.env.TSC_COMPILE_ON_ERROR === 'true';
126126
if (tscCompileOnError) {
127-
console.log(chalk.yellow(
128-
'Compiled with the following type errors (you may want to check these before deploying your app):\n'
129-
));
127+
console.log(
128+
chalk.yellow(
129+
'Compiled with the following type errors (you may want to check these before deploying your app):\n'
130+
)
131+
);
130132
printBuildError(err);
131133
} else {
132134
console.log(chalk.red('Failed to compile.\n'));

0 commit comments

Comments
 (0)