avoid TypeError on when registering service workers without config (#5301)

Peter Bengtsson · Timer · commit e783bf8aed6b · 2018-10-04T22:42:16.000-04:00
* avoid TypeError on when registering service workers without config Fixes #5299 * same before config.onUpdate
diff --git a/packages/react-scripts/template/src/serviceWorker.js b/packages/react-scripts/template/src/serviceWorker.js
@@ -68,7 +68,7 @@ function registerValidSW(swUrl, config) {
               console.log('New content is available; please refresh.');
 
               // Execute callback
-              if (config.onUpdate) {
+              if (config && config.onUpdate) {
                 config.onUpdate(registration);
               }
             } else {
@@ -78,7 +78,7 @@ function registerValidSW(swUrl, config) {
               console.log('Content is cached for offline use.');
 
               // Execute callback
-              if (config.onSuccess) {
+              if (config && config.onSuccess) {
                 config.onSuccess(registration);
               }
             }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ function registerValidSW(swUrl, config) {`
`68`	`68`	`console.log('New content is available; please refresh.');`
`69`	`69`
`70`	`70`	`// Execute callback`
`71`		`- if (config.onUpdate) {`
	`71`	`+ if (config && config.onUpdate) {`
`72`	`72`	`config.onUpdate(registration);`
`73`	`73`	`}`
`74`	`74`	`} else {`
`@@ -78,7 +78,7 @@ function registerValidSW(swUrl, config) {`
`78`	`78`	`console.log('Content is cached for offline use.');`
`79`	`79`
`80`	`80`	`// Execute callback`
`81`		`- if (config.onSuccess) {`
	`81`	`+ if (config && config.onSuccess) {`
`82`	`82`	`config.onSuccess(registration);`
`83`	`83`	`}`
`84`	`84`	`}`