-
-
Notifications
You must be signed in to change notification settings - Fork 27k
i18n support? #1091
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'd love to see a good solution to i18n support in webpack based builds. We initially started with something similar to your example based on I tried to solve this with several hacks. One example is here and another on is here. To work nicely some bugs in webpack would need to be fixed like this one (however I'm still not sure if this is a bug) or we would need new features like this one. Subscribing this thread because I really hope to find a nice solution for this. |
Same here, looking for a the cleanest way to add i18n support into Create React App app without ejecting, maybe there should be some kind of localization section in README? |
+1 Loooooooooooooking forward to it |
I agree this is something we’ll need to address. |
See also #1227 |
what could be the specs of our support for i18n ? |
Is there any dicussion about using i18n vs yahoo internationalization package? |
Just in case, #3675 is merged already, using i18n via a babel macro might be feasible 💃 |
Any updates on this? I was looking for a library primarily for translation of text. Formatting of dates, times and numbers, and time zones is also nice but I guess a separate date library can handle that. I checked out |
Why? I use react-i18next with cra without ejecting and have NOT encountered any issues |
yeah, react-i18next is great! |
there's also https://www.npmjs.com/package/tagged-translations |
We have @enact/i18n which uses iLib under the hood. It's a very comprehensive set of tools for i18n. We have a webpack plugin that handles some of the packaging issues when dealing with i18n. All that is available on npm with an Apache 2.0 license. We'd definitely be interested in seeing if there are ways we could work with the community to make this an option for CRA. For our own apps, we have a cli tool inspired by CRA and preact-cli that is pre-configured with the plugin. |
we've switched from react-18next to https://github.com/lingui/js-lingui bundle size is now less than 15% to what it was with react-18next speed increased about two orders of magnitude compared to before because translations are compiled down to pure js functions |
@markusgattol did you eject to use their webpack plugins? |
Is this issue dead? |
If it helps, here is the cleanest pattern that I could come up with to add i18n without ejecting: Here's a gist: https://gist.github.com/jeffsheets/b465a174eaccd7bd81c075964c0a9c5d |
ttag library allows you to implement localization without eject. You have an option to precompile translations right into the bundle or to apply them at a runtime: Official doc - https://ttag.js.org/docs/create-react-app.html |
This is an important issue, I propose we add an additional page to the To help provide guidance on how best to include Internationalization and Localization support within the We could compile many of the recommendations from this thread in a clear and easy to consume way - to make the process of including i18n easier for folks. I think this would be very useful for the community and am happy to help write it up. 🌏 🌍 🌎 |
Any recommendations on what library to use for internationalization ? |
@ahmedosama5200 , |
Any plans to add support for i18n?
I've had previous success with i18n webpack plugin - perhaps this could be integrated into the webpack configuration?
Given that it increases build time significantly (as it makes use of webpack's multi-compiler feature i.e.
module.exports = [configA, configB];
instead ofmodule.exports = config;
), it would most likely have to be an opt in feature. We could look for ani18n/
directory that users could drop a bunch of json files into the like so:The idea that CRA would produce an output bundle per locale in conjunction with i18n webpack plugin.
Thoughts? Happy to attempt a PR if you have no objections.
The text was updated successfully, but these errors were encountered: