Using react-scripts from parent folder results in strange behaviour

[ashtonsix]

Background

I'm building a library with several examples, these examples use create-react-app but I don't want people to waste lots of time by repeatedly installing react-scripts. So I moved the react-scripts dependency to the project root.

Steps to reproduce

Run the following inside an empty folder:

npm install -g [email protected]
npm install --save [email protected] [email protected]
npm install --save-dev [email protected]
mkdir examples
cd examples
create-react-app counter
cd counter
npm uninstall --save react react-dom
npm uninstall --save-dev react-scripts
npm start

Navigate to localhost:3000 and you might see something like:

Which can be fixed by moving examples/counter/public/index.html to examples/counter/index.html (though some additional errors are reported in the console like URIError: Failed to decode param '/%PUBLIC_URL%/favicon.ico').

This seems like behavior from an older version of react-scripts but I'm not sure.

Environment

node -v # 6.2.0
npm -v  # 3.10.5
# Windows 7
# Chrome 54

[gaearon]

Why did you close this? Is it solved?

[ashtonsix]

I clicked the button by mistake

[gaearon]

How can we solve this? Would changing this to be based on __dirname work?

[ashtonsix]

Just tried that, changing process.cwd() to __dirname has no effect.

I've found switching from npm to yarn significantly improves installation times making the original solution unnecessary ie, this issue no longer affects me. The issue remains but I'm not personally motivated to fix it anymore. But thanks for the help (& sorry I took ages to respond)!

[ashtonsix]

Keep seeing "close" in OctoDroid + thinking it means "back"

[Timer]

Duplicate of #556. Going to close this. 😄