Skip to content

Consider new ESLint rules #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaearon opened this issue Oct 28, 2017 · 4 comments
Closed

Consider new ESLint rules #3341

gaearon opened this issue Oct 28, 2017 · 4 comments
Labels
tag: breaking change tag: enhancement
Milestone
2.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 28, 2017

There's been a bunch added from ESLint 4.4.x to 4.10.x. We should enable non-controversial ones in a future breaking change release.
@Timer Timer added this to the 2.0.0 milestone Oct 28, 2017
@chrislaughlin
Copy link
Contributor

Is this open for PR if so I can take a look.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 9, 2018

Sure.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 9, 2018

(Please look if there's already a PR—we haven't reviewed them in a while and need to clean them up)

@chrislaughlin chrislaughlin mentioned this issue Jan 9, 2018
Merged
@gaearon
Copy link
Contributor Author

gaearon commented Jan 20, 2018

Fixed by #3723

@gaearon gaearon closed this as completed Jan 20, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: breaking change tag: enhancement
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@chrislaughlin @Timer @gaearon