Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to optimize-css-assets-webpack-plugin v5 #4771

Closed
Hoolean opened this issue Jul 16, 2018 · 3 comments
Closed

Upgrade to optimize-css-assets-webpack-plugin v5 #4771

Hoolean opened this issue Jul 16, 2018 · 3 comments

Comments

@Hoolean
Copy link

Hoolean commented Jul 16, 2018

Is this a bug report?

No.

What

react-scripts uses optimize-css-assets-webpack-plugin v4 for builds.

v5 has been released.

It would be great to bump the version for 2.0.0.

Why

cssnano v4 has been released.

It would be great to enjoy these improvements downstream.
@bugzpodder
Copy link

this PR might also render #4706 unneceessary because cssnano v4 essentially only turn on safeoptions.

@Hoolean
Copy link
Author

Hoolean commented Jul 17, 2018

The move to safe options is actually exactly why I felt an upgrade would be beneficial; I had similar z-index issues.

@kurtbartholomew
Copy link

v5 of optimize-css-assets-webpack-plugin has been added.
Can this issue be closed @bugzpodder ?

@Timer Timer closed this as completed Oct 15, 2018
@lock lock bot locked and limited conversation to collaborators Jan 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Timer @Hoolean @kurtbartholomew @bugzpodder