Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDom 11.12 causes tests to fail #4869

Closed
iansu opened this issue Aug 9, 2018 · 2 comments
Closed

JSDom 11.12 causes tests to fail #4869

iansu opened this issue Aug 9, 2018 · 2 comments

Comments

@iansu
Copy link
Contributor

iansu commented Aug 9, 2018

It looks like the latest version of JSDom is incompatible with one of the default settings in Jest.

Here's the Jest issue: jestjs/jest#6766

This appears to have been fixed but not yet released: jestjs/jest#6792

Even when the fix is released we will still be running an older version of Jest that may not be updated. I think our options for fixing this are:

  1. Update to a newer version of Jest (I think there is at least one PR in the works to do this)
  2. Add testURL: 'http://localhost' to our Jest config
@iansu
Copy link
Contributor Author

iansu commented Aug 11, 2018

On further investigation it looks like we already have testURL: 'http://localhost in our Jest config here: https://github.com/facebook/create-react-app/blob/next/packages/react-scripts/scripts/utils/createJestConfig.js#L37

@skoging
Copy link
Contributor

skoging commented Aug 14, 2018

The fix has been released with Jest 23.5 and the PR has been updated: #4846

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants