-
-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change destination for shortened links #5536
Comments
Does bit.ly have an open source plan? 😀 Since these links are already out there and we can't really change them maybe we should just have placeholders for them in the README. Then the link still works and we can just point them to the corresponding page in the new docs. |
I'm sure an email to them could get this straightened out. 😄 |
They don't currently have an open source plan. An Enterprise plan is the only listed paid plan they offer. Reaching out to them also doesn't hurt. |
@bondz could you reach out since the link (I assume) is associated with your account? |
@Timer yes, I would. Maybe I could copy you in the mail? |
Sure you can copy me! |
Sent the mail to @bitly still waiting for a response. |
More broken shortlinks here: #5617. |
I tried reaching out to @bitly on Twitter and they just told me to email support. I sent another email but I'm not optimistic about getting a response. I think we might just have to add some placeholders in the README for people using those links like I mentioned above. |
Finally got feedbackfrom @bitly support.
We need to change those links and add placeholders. |
I've created a PR that adds placeholders to the template README: #5808 I think we should also change these links in template but I'm not sure what we want to change them to. We could use a different link shortner or we could make new bit.ly links but I really don't want to end up in this same situation again. |
Doesn't look like @bitly would yield and let us change the target destination of those links. This is continuing to affect lots of users. @iansu fixes this is #5808. We could merge that. Also, as noted by @iansu in that PR. There are other goo.gl shortlinks throughout the codebase, we should start thinking of changing those too. |
The shortened bit.ly links in the project would not redirect to the website since bitly doesn't let users except enterprise users change the destination of links.
This poses a problem for all the shortlinks that are already in the wild, as all of them would now redirect to https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md
We have a few options, switch to a service that lets us edit the destination of shortlinks, like
page.links
orrebrandly
This still leaves us with problems like in #5497
Second, we could document in the readme the new destination for the links, this would help the more than 4k people who clicked on the PWA link alone this month.
cc @Timer
The text was updated successfully, but these errors were encountered: