Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change destination for shortened links #5536

Closed
bondz opened this issue Oct 23, 2018 · 14 comments
Closed

Change destination for shortened links #5536

bondz opened this issue Oct 23, 2018 · 14 comments

Comments

@bondz
Copy link
Contributor

bondz commented Oct 23, 2018

The shortened bit.ly links in the project would not redirect to the website since bitly doesn't let users except enterprise users change the destination of links.

This poses a problem for all the shortlinks that are already in the wild, as all of them would now redirect to https://github.com/facebook/create-react-app/blob/master/packages/react-scripts/template/README.md

We have a few options, switch to a service that lets us edit the destination of shortlinks, like

page.links or rebrandly

This still leaves us with problems like in #5497

Second, we could document in the readme the new destination for the links, this would help the more than 4k people who clicked on the PWA link alone this month.

cc @Timer

@iansu
Copy link
Contributor

iansu commented Oct 23, 2018

Does bit.ly have an open source plan? 😀

Since these links are already out there and we can't really change them maybe we should just have placeholders for them in the README. Then the link still works and we can just point them to the corresponding page in the new docs.

@Timer
Copy link
Contributor

Timer commented Oct 23, 2018

I'm sure an email to them could get this straightened out. 😄

@bondz
Copy link
Contributor Author

bondz commented Oct 23, 2018

They don't currently have an open source plan. An Enterprise plan is the only listed paid plan they offer.

Reaching out to them also doesn't hurt.

@Timer
Copy link
Contributor

Timer commented Oct 23, 2018

@bondz could you reach out since the link (I assume) is associated with your account?

@bondz
Copy link
Contributor Author

bondz commented Oct 23, 2018

@Timer yes, I would. Maybe I could copy you in the mail?

@Timer
Copy link
Contributor

Timer commented Oct 23, 2018

Sure you can copy me!

@bondz
Copy link
Contributor Author

bondz commented Oct 25, 2018

Sent the mail to @bitly still waiting for a response.

@iansu
Copy link
Contributor

iansu commented Oct 29, 2018

More broken shortlinks here: #5617.

@bondz
Copy link
Contributor Author

bondz commented Oct 31, 2018

This is increasingly going to affect a lot of users and I've not gotten any response from @bitly. We could proceed to change the URLs for new versions. cc @Timer

@ghost ghost mentioned this issue Oct 31, 2018
@iansu
Copy link
Contributor

iansu commented Oct 31, 2018

I tried reaching out to @bitly on Twitter and they just told me to email support. I sent another email but I'm not optimistic about getting a response.

I think we might just have to add some placeholders in the README for people using those links like I mentioned above.

@bondz
Copy link
Contributor Author

bondz commented Nov 1, 2018

Finally got feedbackfrom @bitly support.

We apologize for the delayed response here, however, unfortunately, we aren't able to redirect the link on the the version of the platform you're using.
If you'd like to speak with a Sales Representative to discuss the details of upgrading your account.

We need to change those links and add placeholders.

@iansu
Copy link
Contributor

iansu commented Nov 14, 2018

I've created a PR that adds placeholders to the template README: #5808

I think we should also change these links in template but I'm not sure what we want to change them to. We could use a different link shortner or we could make new bit.ly links but I really don't want to end up in this same situation again.

@bondz
Copy link
Contributor Author

bondz commented Nov 27, 2018

Doesn't look like @bitly would yield and let us change the target destination of those links. This is continuing to affect lots of users. @iansu fixes this is #5808. We could merge that.

Also, as noted by @iansu in that PR. There are other goo.gl shortlinks throughout the codebase, we should start thinking of changing those too.

@iansu
Copy link
Contributor

iansu commented Nov 27, 2018

We've merged #5808 and I've created a follow up #5910 to remove the bit.ly links from the template so I think we can close this now.

@bondz bondz closed this as completed Nov 27, 2018
@lock lock bot locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants