Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated docs with regards to eslint #6083

Closed
LukasWerfel opened this issue Dec 22, 2018 · 1 comment · Fixed by #6084
Closed

Outdated docs with regards to eslint #6083

LukasWerfel opened this issue Dec 22, 2018 · 1 comment · Fixed by #6084

Comments

@LukasWerfel
Copy link
Contributor

LukasWerfel commented Dec 22, 2018

Hi there,
I got a question regarding the docs.

In the section "Displaying Lint Output in the Editor" it says:

Then, add a file called .eslintrc to the project root

This does not seem to be the case anymore, since eslintConfig was added here.

If I understand correctly, that would mean that the docs are a bit outdated.

Since I am looking for my very first PR, I was wondering if I may open a PR (with some guidance) in order to fix this.

@Timer
Copy link
Contributor

Timer commented Dec 23, 2018

This only affects newly created projects, so I think we can come up with something instead of removing it all -- let's continue discussion on the PR. Thanks!

@Timer Timer closed this as completed Dec 23, 2018
@lock lock bot locked and limited conversation to collaborators Jan 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants