Skip to content

Remove bundledDependencies #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gaearon opened this issue Oct 29, 2016 · 8 comments
Closed

Remove bundledDependencies #986

gaearon opened this issue Oct 29, 2016 · 8 comments
Milestone
0.8.0

Comments

@gaearon
Copy link
Contributor

gaearon commented Oct 29, 2016

We've had too many issues related to how the buggy npm client treats bundledDependencies.

Since LTS Node is now shipped with npm@3, we should remove bundledDependencies, bump npm version in engines field, and mention that we are npm@3+ in README.
@gaearon gaearon mentioned this issue Oct 29, 2016
Merged
@thien-do thien-do mentioned this issue Nov 3, 2016
Closed
@kitze kitze mentioned this issue Nov 5, 2016
Closed
@thien-do
Copy link
Contributor

Is there anyone working on this? If not, I think I can do. Is this similar with this one kitze@cdaa892

@gaearon gaearon added this to the 0.8.0 milestone Nov 20, 2016
@gaearon
Copy link
Contributor Author

gaearon commented Nov 20, 2016

@dvkndn 👍

@thien-do
Copy link
Contributor

Ok I'll make a PR for this one. All credit to @kitze

@kitze
Copy link

kitze commented Nov 21, 2016

@dvkndn finally. I'm not sure if that was causing this issue though, some people still have problems on specific verisons of npm 😥

@thien-do
Copy link
Contributor

actually @fson worked on this already :D #1068

@fson
Copy link
Contributor

fson commented Nov 21, 2016

Oh yeah, sorry for not commenting on this issue. I needed this for fixing the ESLint integration and forgot that there was a separate issue about this.

@thien-do
Copy link
Contributor

Don't worry, I haven't started yet 😄

@fson
Copy link
Contributor

fson commented Nov 22, 2016

Fixed in #1068.

@fson fson closed this as completed Nov 22, 2016
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

No branches or pull requests
4 participants
@fson @gaearon @kitze @thien-do