From 256d705e30381fe8256fea9907c5bc34e8f7bf87 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 6 Mar 2017 10:49:55 -0500 Subject: [PATCH 1/3] Switch to preset-env Disables webpack modules by enabling babel modules to resolve #1638 --- packages/babel-preset-react-app/index.js | 11 +++++++---- packages/babel-preset-react-app/package.json | 17 ++++++++--------- 2 files changed, 15 insertions(+), 13 deletions(-) diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js index 3760ec4e1ae..fecb81c035b 100644 --- a/packages/babel-preset-react-app/index.js +++ b/packages/babel-preset-react-app/index.js @@ -84,10 +84,13 @@ if (env === 'test') { module.exports = { presets: [ // Latest stable ECMAScript features - [require.resolve('babel-preset-latest'), { - 'es2015': { - modules: false - } + [require.resolve('babel-preset-env'), { + targets: { + // We support everything React supports + 'ie': 9 + }, + // Disable polyfill transforms + useBuiltIns: false }], // JSX, Flow require.resolve('babel-preset-react') diff --git a/packages/babel-preset-react-app/package.json b/packages/babel-preset-react-app/package.json index 049d75db3ee..aa955e43762 100644 --- a/packages/babel-preset-react-app/package.json +++ b/packages/babel-preset-react-app/package.json @@ -13,17 +13,16 @@ "dependencies": { "babel-plugin-dynamic-import-node": "1.0.0", "babel-plugin-syntax-dynamic-import": "6.18.0", - "babel-plugin-transform-class-properties": "6.22.0", - "babel-plugin-transform-object-rest-spread": "6.22.0", - "babel-plugin-transform-react-constant-elements": "6.22.0", - "babel-plugin-transform-react-jsx": "6.22.0", + "babel-plugin-transform-class-properties": "6.23.0", + "babel-plugin-transform-object-rest-spread": "6.23.0", + "babel-plugin-transform-react-constant-elements": "6.23.0", + "babel-plugin-transform-react-jsx": "6.23.0", "babel-plugin-transform-react-jsx-self": "6.22.0", "babel-plugin-transform-react-jsx-source": "6.22.0", "babel-plugin-transform-regenerator": "6.22.0", - "babel-plugin-transform-runtime": "6.22.0", - "babel-preset-env": "1.1.8", - "babel-preset-latest": "6.22.0", - "babel-preset-react": "6.22.0", - "babel-runtime": "6.22.0" + "babel-plugin-transform-runtime": "6.23.0", + "babel-preset-env": "1.2.1", + "babel-preset-react": "6.23.0", + "babel-runtime": "6.23.0" } } From 195df075f9ef03f61c2d589370f90672fbfd5c90 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 6 Mar 2017 16:25:01 -0500 Subject: [PATCH 2/3] Bump babel-core to match babel preset versions --- packages/react-scripts/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-scripts/package.json b/packages/react-scripts/package.json index 539b11fd813..b17d74dcfa6 100644 --- a/packages/react-scripts/package.json +++ b/packages/react-scripts/package.json @@ -24,7 +24,7 @@ }, "dependencies": { "autoprefixer": "6.7.5", - "babel-core": "6.22.1", + "babel-core": "6.23.1", "babel-eslint": "7.1.1", "babel-jest": "18.0.0", "babel-loader": "6.3.2", From e74b9af1f94831c0ac6f60014d6cbe2a304cca64 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Mon, 6 Mar 2017 16:28:59 -0500 Subject: [PATCH 3/3] Add uglify to targets --- packages/babel-preset-react-app/index.js | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/babel-preset-react-app/index.js b/packages/babel-preset-react-app/index.js index fecb81c035b..8236c64b54c 100644 --- a/packages/babel-preset-react-app/index.js +++ b/packages/babel-preset-react-app/index.js @@ -86,8 +86,11 @@ if (env === 'test') { // Latest stable ECMAScript features [require.resolve('babel-preset-env'), { targets: { - // We support everything React supports - 'ie': 9 + // React parses on ie 9, so we should too + ie: 9, + // We currently minify with uglify + // Remove after https://github.com/mishoo/UglifyJS2/issues/448 + uglify: true }, // Disable polyfill transforms useBuiltIns: false