From 166ba48158f0b0a23352918a23d7b6cb644e8178 Mon Sep 17 00:00:00 2001 From: Alison Monteiro Date: Thu, 4 May 2017 01:00:09 -0300 Subject: [PATCH 1/2] react-dev-utils/openBrowser now supports urls with 2+ params Fixed #2047 --- packages/react-dev-utils/openBrowser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/openBrowser.js b/packages/react-dev-utils/openBrowser.js index 8c97f723c4f..0b888ff0026 100644 --- a/packages/react-dev-utils/openBrowser.js +++ b/packages/react-dev-utils/openBrowser.js @@ -38,7 +38,7 @@ function openBrowser(url) { // Try our best to reuse existing tab // on OS X Google Chrome with AppleScript execSync('ps cax | grep "Google Chrome"'); - execSync('osascript openChrome.applescript ' + url, { + execSync('osascript openChrome.applescript "' + url + '"', { cwd: __dirname, stdio: 'ignore', }); From 322a171d0c4a69bb130a26d26dba724814ba957b Mon Sep 17 00:00:00 2001 From: Alison Monteiro Date: Mon, 15 May 2017 23:10:58 -0300 Subject: [PATCH 2/2] react-dev-utils/openBrowser: encode url before open the browser --- packages/react-dev-utils/openBrowser.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-dev-utils/openBrowser.js b/packages/react-dev-utils/openBrowser.js index 0b888ff0026..31795676b46 100644 --- a/packages/react-dev-utils/openBrowser.js +++ b/packages/react-dev-utils/openBrowser.js @@ -38,7 +38,7 @@ function openBrowser(url) { // Try our best to reuse existing tab // on OS X Google Chrome with AppleScript execSync('ps cax | grep "Google Chrome"'); - execSync('osascript openChrome.applescript "' + url + '"', { + execSync('osascript openChrome.applescript "' + encodeURI(url) + '"', { cwd: __dirname, stdio: 'ignore', });