From db5809bdd2a556f4fa3771430a5a986d5411bbc9 Mon Sep 17 00:00:00 2001 From: Wataru Ashihara Date: Sun, 4 Aug 2019 17:23:26 +0900 Subject: [PATCH] Fix notations of loopback addresses 127.0.0.1/8 refers to only a single IPv4 address "127.0.0.1" that have the subnet mask 255.255.255.0, but doesn't to 127.0.0.2. 127.0.0.0/8, which is the exact definition of the loopback addresses [1][2], includes what the regex says (127.0.0.0-127.255.255.255). [1] https://tools.ietf.org/html/rfc1122 [2] https://tools.ietf.org/html/rfc6890 --- packages/react-scripts/template-typescript/src/serviceWorker.ts | 2 +- packages/react-scripts/template/src/serviceWorker.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/react-scripts/template-typescript/src/serviceWorker.ts b/packages/react-scripts/template-typescript/src/serviceWorker.ts index 15d90cb81a1..accd72b6f3d 100644 --- a/packages/react-scripts/template-typescript/src/serviceWorker.ts +++ b/packages/react-scripts/template-typescript/src/serviceWorker.ts @@ -14,7 +14,7 @@ const isLocalhost = Boolean( window.location.hostname === 'localhost' || // [::1] is the IPv6 localhost address. window.location.hostname === '[::1]' || - // 127.0.0.1/8 is considered localhost for IPv4. + // 127.0.0.0/8 are considered localhost for IPv4. window.location.hostname.match( /^127(?:\.(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}$/ ) diff --git a/packages/react-scripts/template/src/serviceWorker.js b/packages/react-scripts/template/src/serviceWorker.js index f8c7e50c201..ceeed83fce8 100644 --- a/packages/react-scripts/template/src/serviceWorker.js +++ b/packages/react-scripts/template/src/serviceWorker.js @@ -14,7 +14,7 @@ const isLocalhost = Boolean( window.location.hostname === 'localhost' || // [::1] is the IPv6 localhost address. window.location.hostname === '[::1]' || - // 127.0.0.1/8 is considered localhost for IPv4. + // 127.0.0.0/8 are considered localhost for IPv4. window.location.hostname.match( /^127(?:\.(?:25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)){3}$/ )