You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
commit orphaned; update hash for graphql-parser patch
Summary:
Currently, `Cargo.toml` files generated by `autocargo` contain the following line:
https://www.internalfb.com/code/fbsource/[159701a8d991]/fbcode/eden/scm/public_autocargo/Cargo.toml?lines=7
At the time of this writing, GitHub still appears to know about
`1d155d96e6052767380ab5e67c57e3d6608a31ac`, as it was recently "orphaned"
(i.e., it does not belong to a branch), but because it is "orphaned," it appears that
GitHub refuses to tell `cargo` about it when it requests it, which breaks builds.
To create this diff, I updated the `[patch.crates-io]` section in `third-party/rust/Cargo.toml`
and then ran `fbcode/common/rust/cargo_from_buck/bin/autocargo`. I replaced
`1d155d96e6052767380ab5e67c57e3d6608a31ac` with the new head of
graphql-rust/graphql-parser#66, which is
`c778917f57f6b2c26d9291819b9bb341a2f5948a`.
What happened? Here's what it looks like:
- After discovering that our `Cargo.toml` files created by `autocargo` contained massive
`[patch.crates-io]` sections that appeared to be slowing down our open source build,
I went and posted about it in the Source Control Team group:
https://fb.workplace.com/groups/sourcecontrolteam/posts/5310340079087295
- One way to improve the situation is to eliminate these patches from `//third-party/rust`,
so I spot-checked a number of the patches, tracking down the diff that introduced them,
and attempted to follow-up with the author to upstream the patch.
- D37532244 appeared to be the diff that pulled in the patch for `graphql-parser`.
In the comments, I pinged the author (vmagro) to see if he could upstream his patch.
- Vinnie agreed and updated his PR: graphql-rust/graphql-parser#66
- *what appears to have happened* is that Vinnie updated the PR by doing a "force push"
where the previous head was `1d155d96e6052767380ab5e67c57e3d6608a31ac` and
the new head is `c778917f57f6b2c26d9291819b9bb341a2f5948a`.
- GitHub...does not like force pushes. Indeed, if you visit
graphql-rust/graphql-parser@1d155d9
you see a yellow warning banner at the top that says
**This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.**
I don't know what call `cargo` makes to resolve these `git` dependencies, but I assume
GitHub is refusing to respond as it normally would for orphaned commits such as these.
Reviewed By: fanzeyi
Differential Revision: D39190591
fbshipit-source-id: b8d1187cdec9312e9215b28020a735058faeb2d7
0 commit comments