[build] remove unused ocamlopt-custom-cc

Summary:
Not sure when this became dead but it doesn't even work since
nothing makes use of `extra_cflags`.

Reviewed By: dulmarod

Differential Revision:
D71981207

Privacy Context Container: L1208441

fbshipit-source-id: 6af5799c76b0838f4bc67a9ae0aeecdeb01eb690

Author: jvillard

Makefile.autoconf.in

@@ -31,7 +31,6 @@ CXXFLAGS := @CXXFLAGS@
 # this is useless but autoconf is picky...
 datarootdir = @datarootdir@
 EMACS := @EMACS@
-ENABLE_OCAMLOPT_CUSTOM_CC := @ENABLE_OCAMLOPT_CUSTOM_CC@
 ENABLE_OCAML_BINANNOT := @ENABLE_OCAML_BINANNOT@
 ERLC := @ERLC@
 ESCRIPT := @ESCRIPT@

configure.ac

@@ -189,12 +189,6 @@ AS_IF([test "x$enable_c_analyzers" = "xyes"], [
   # cmake is required to build llvm+clang
   AC_CHECK_TOOL([CMAKE], [cmake], [no])
   AC_ASSERT_PROG([cmake], [$CMAKE])
-  AC_ARG_ENABLE(ocamlopt-custom-cc,
-    AS_HELP_STRING([--enable-ocamlopt-custom-cc], [use CC in ocamlopt invocations]),
-    ,
-    enable_ocamlopt_custom_cc=no)
-  ENABLE_OCAMLOPT_CUSTOM_CC=$enable_ocamlopt_custom_cc
-  AC_SUBST([ENABLE_OCAMLOPT_CUSTOM_CC])
 ])
 # end if($enable_c_analyzers)
 

infer/src/Makefile

@@ -31,13 +31,7 @@ FCP_CLANG_AST_PROJ = $(addprefix $(FCP_CLANG_OCAML_BUILD_DIR)/, \
 FCP_CLANG_AST_MAIN = $(addprefix $(FCP_CLANG_OCAML_DIR)/, clang_ast_visit.ml clang_ast_types.ml)
 FCP_FILES_TO_MIRROR = $(FCP_CLANG_AST_PROJ) $(FCP_CLANG_AST_MAIN)
 CLANG_PLUGIN_MIRRORED_FILES = $(addprefix $(CLANG_PLUGIN_MIRROR)/, $(notdir $(FCP_FILES_TO_MIRROR)))
-
 CLANG_BINIOU_DICT = $(ETC_DIR)/clang_ast.dict
-
-ifeq ($(ENABLE_OCAMLOPT_CUSTOM_CC),yes)
-EXTRA_CFLAGS += -cc,$(CC)
-endif
-
 OCAML_GENERATED_SOURCES = base/Version.ml
 
 ifeq ($(BUILD_C_ANALYZERS),yes)
@@ -240,7 +234,6 @@ $(GENERATED_FROM_AUTOCONF): $(MAKEFILE_LIST)
 	INFER_GIT_COMMIT=$$(git --work-tree=$(ROOT_DIR) --git-dir=$(ROOT_DIR)/.git rev-parse --short HEAD || printf "unknown"); \
 	INFER_GIT_BRANCH=$$(git --work-tree=$(ROOT_DIR) --git-dir=$(ROOT_DIR)/.git rev-parse --abbrev-ref HEAD || printf "unknown"); \
 	sed \
-	  -e 's|@EXTRA_CFLAGS[@]|$(EXTRA_CFLAGS)|g' \
 	  -e 's|@INFER_MAJOR[@]|$(INFER_MAJOR)|g' \
 	  -e 's|@INFER_MINOR[@]|$(INFER_MINOR)|g' \
 	  -e 's|@INFER_PATCH[@]|$(INFER_PATCH)|g' \

infer/src/dune.common.in

@@ -25,8 +25,6 @@ let swift = is_yes "@BUILD_SWIFT_ANALYZERS@"
 
 let facebook = is_yes "@IS_FACEBOOK_TREE@"
 
-let extra_cflags = if is_empty "@EXTRA_CFLAGS@" then [] else ["@EXTRA_CFLAGS@"]
-
 let windows = is_yes "@WINDOWS_BUILD@"
 
 let darwin = String.equal "@BUILD_PLATFORM@" "Darwin"