Skip to content

Commit 0182086

Browse files
Adrien Thieryfacebook-github-bot
Adrien Thiery
authored andcommitted
Disable git hooks for the upgrade process
Summary: I'm loving `react-native-git-upgrade`, such a life and time saver, but when doing the upgrade, if git hooks are defined globally to be applied, `react-native-git-upgrade` uses these git hooks, although they might not be relevant to the upgrade process (and potentially make it way longer). Btw, thanks ncuillery for the great tool 😄 To test, I : * cloned my project * upgraded it with the npm published `react-native-git-upgrade` version : Git hooks are running during the upgrade * cloned the `react-native` repo * did my modifications on the `react-native-git-upgrade/cliEntry.js` file * `npm i -g react-native-git-upgrade/` after running `yarn` in that folder * Re-cloned my project in another folder * Upgraded it with `react-native-git-upgrade` : The hooks are not running anymore, yay! [CLI] [ENHANCEMENT] [react-native/react-native-git-upgrade] - Do not run git hooks in the upgrade process I plan to add an option to the cli so you can pass `--verify` or `--use-git-hooks` if you DO want your git hooks to run, but don't have the time right now and I think the default should be to not run them. Closes #16855 Differential Revision: D6353781 Pulled By: hramos fbshipit-source-id: e4b0f55d10c37bc805b32cb4c0fe3c863346482d
1 parent 52e3ae9 commit 0182086

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

react-native-git-upgrade/cliEntry.js

+4-4
Original file line numberDiff line numberDiff line change
@@ -278,7 +278,7 @@ async function run(requestedVersion, cliArgs) {
278278
await exec('git add .', verbose);
279279

280280
log.info('Commit current project sources');
281-
await exec('git commit -m "Project snapshot"', verbose);
281+
await exec('git commit -m "Project snapshot" --no-verify', verbose);
282282

283283
log.info('Create a tag before updating sources');
284284
await exec('git tag project-snapshot', verbose);
@@ -291,7 +291,7 @@ async function run(requestedVersion, cliArgs) {
291291
await exec('git add .', verbose);
292292

293293
log.info('Commit old version template');
294-
await exec('git commit -m "Old version" --allow-empty', verbose);
294+
await exec('git commit -m "Old version" --allow-empty --no-verify', verbose);
295295

296296
log.info('Install the new version');
297297
let installCommand;
@@ -314,7 +314,7 @@ async function run(requestedVersion, cliArgs) {
314314
await exec('git add .', verbose);
315315

316316
log.info('Commit new version template');
317-
await exec('git commit -m "New version" --allow-empty', verbose);
317+
await exec('git commit -m "New version" --allow-empty --no-verify', verbose);
318318

319319
log.info('Generate the patch between the 2 versions');
320320
const diffOutput = await exec('git diff --binary --no-color HEAD~1 HEAD', verbose);
@@ -345,7 +345,7 @@ async function run(requestedVersion, cliArgs) {
345345
log.error(err.stack);
346346
if (projectBackupCreated) {
347347
log.error('Restore initial sources');
348-
await exec('git checkout project-snapshot', true);
348+
await exec('git checkout project-snapshot --no-verify', true);
349349
}
350350
}
351351
}

0 commit comments

Comments
 (0)