Skip to content

Commit 0314fca

Browse files
sunnylqmfacebook-github-bot
authored andcommittedDec 11, 2018
Use relative path for SCRIPTDIR (#22598)
Summary: Fixes #22521 The current approach has an issue with white spaces when compiling in Xcode 10.1 ![space](https://user-images.githubusercontent.com/615282/49782648-07836f80-fd52-11e8-952f-b93f8c593c60.png) Change back to relative path fixes this issue Pull Request resolved: #22598 Differential Revision: D13421446 Pulled By: hramos fbshipit-source-id: 688157b2e951399059cb6c95e2a6ce8d176e9b9c
1 parent aeaeac8 commit 0314fca

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎scripts/ios-install-third-party.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ function fetch_and_unpack () {
6363

6464
mkdir -p third-party
6565

66-
SCRIPTDIR=$(cd $(dirname "$0") && pwd)
66+
SCRIPTDIR=$(dirname "$0")
6767

6868
fetch_and_unpack glog-0.3.5.tar.gz https://github.com/google/glog/archive/v0.3.5.tar.gz 61067502c5f9769d111ea1ee3f74e6ddf0a5f9cc "\"$SCRIPTDIR/ios-configure-glog.sh\""
6969
fetch_and_unpack double-conversion-1.1.6.tar.gz https://github.com/google/double-conversion/archive/v1.1.6.tar.gz 1c7d88afde3aaeb97bb652776c627b49e132e8e0

0 commit comments

Comments
 (0)
Please sign in to comment.