Skip to content

Commit 0ae4c47

Browse files
sherginfacebook-github-bot
authored andcommittedDec 20, 2017
-[UIView _DEBUG_reactShadowView] was removed
Summary: Nobody uses it. If the reference to the bridge is available (which is should be case for testing purposes at least), it is easy to get same information. Reviewed By: mmmulani Differential Revision: D6596376 fbshipit-source-id: 066eeb1e9465b4e0cc9d9b5b6bf41722450870e4
1 parent c79246d commit 0ae4c47

File tree

3 files changed

+0
-29
lines changed

3 files changed

+0
-29
lines changed
 

‎React/Modules/RCTUIManager.m

-4
Original file line numberDiff line numberDiff line change
@@ -976,10 +976,6 @@ - (void)_manageChildren:(NSNumber *)containerTag
976976
if (view) {
977977
[componentData setProps:props forView:view];
978978
uiManager->_viewRegistry[reactTag] = view;
979-
980-
#if RCT_DEV
981-
[view _DEBUG_setReactShadowView:shadowView];
982-
#endif
983979
}
984980
});
985981

‎React/Views/UIView+React.h

-10
Original file line numberDiff line numberDiff line change
@@ -109,14 +109,4 @@
109109
*/
110110
@property (nonatomic, readonly) UIView *reactAccessibilityElement;
111111

112-
#if RCT_DEV
113-
114-
/**
115-
Tools for debugging
116-
*/
117-
118-
@property (nonatomic, strong, setter=_DEBUG_setReactShadowView:) RCTShadowView *_DEBUG_reactShadowView;
119-
120-
#endif
121-
122112
@end

‎React/Views/UIView+React.m

-15
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,6 @@ - (void)setNativeID:(NSNumber *)nativeID
3737
objc_setAssociatedObject(self, @selector(nativeID), nativeID, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
3838
}
3939

40-
#if RCT_DEV
41-
42-
- (RCTShadowView *)_DEBUG_reactShadowView
43-
{
44-
return objc_getAssociatedObject(self, _cmd);
45-
}
46-
47-
- (void)_DEBUG_setReactShadowView:(RCTShadowView *)shadowView
48-
{
49-
// Use assign to avoid keeping the shadowView alive it if no longer exists
50-
objc_setAssociatedObject(self, @selector(_DEBUG_reactShadowView), shadowView, OBJC_ASSOCIATION_ASSIGN);
51-
}
52-
53-
#endif
54-
5540
- (BOOL)isReactRootView
5641
{
5742
return RCTIsReactRootView(self.reactTag);

0 commit comments

Comments
 (0)