Skip to content

Commit 21290b5

Browse files
sherginfacebook-github-bot
shergin
authored and
facebook-github-bot
committed
Fabric: Enable all Fabric tests for Android
Summary: All our C++ Fabric tests are cross-platform, so it makes sense to run them for all platforms (especially because platform may behaive differently). Reviewed By: JoshuaGross, mdvacca Differential Revision: D13984574 fbshipit-source-id: e384c03c7f9839be38a1910e04ba2f7725abc378
1 parent 6a71d51 commit 21290b5

File tree

16 files changed

+24
-72
lines changed

16 files changed

+24
-72
lines changed

‎ReactCommon/fabric/attributedstring/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ rn_xplat_cxx_library(
3838
],
3939
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4040
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
41-
fbobjc_tests = [
42-
":tests",
43-
],
4441
force_static = True,
4542
macosx_tests_override = [],
4643
platforms = (ANDROID, APPLE),
4744
preprocessor_flags = [
4845
"-DLOG_TAG=\"ReactNative\"",
4946
"-DWITH_FBSYSTRACE=1",
5047
],
51-
tests = [],
48+
tests = [":tests"],
5249
visibility = ["PUBLIC"],
5350
deps = [
5451
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/components/activityindicator/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -25,16 +25,13 @@ rn_xplat_cxx_library(
2525
],
2626
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
2727
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
28-
fbobjc_tests = [
29-
":tests",
30-
],
3128
macosx_tests_override = [],
3229
platforms = (ANDROID, APPLE),
3330
preprocessor_flags = [
3431
"-DLOG_TAG=\"ReactNative\"",
3532
"-DWITH_FBSYSTRACE=1",
3633
],
37-
tests = [],
34+
tests = [":tests"],
3835
visibility = ["PUBLIC"],
3936
deps = [
4037
"xplat//fbsystrace:fbsystrace",
@@ -60,7 +57,7 @@ fb_xplat_cxx_test(
6057
"-std=c++14",
6158
"-Wall",
6259
],
63-
platforms = APPLE,
60+
platforms = (ANDROID, APPLE),
6461
deps = [
6562
"xplat//folly:molly",
6663
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/components/image/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,13 @@ rn_xplat_cxx_library(
3535
],
3636
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
3737
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
38-
fbobjc_tests = [
39-
":tests",
40-
],
4138
macosx_tests_override = [],
4239
platforms = (ANDROID, APPLE),
4340
preprocessor_flags = [
4441
"-DLOG_TAG=\"ReactNative\"",
4542
"-DWITH_FBSYSTRACE=1",
4643
],
47-
tests = [],
44+
tests = [":tests"],
4845
visibility = ["PUBLIC"],
4946
deps = [
5047
"xplat//fbsystrace:fbsystrace",
@@ -73,7 +70,7 @@ fb_xplat_cxx_test(
7370
"-Wall",
7471
],
7572
contacts = ["[email protected]"],
76-
platforms = APPLE,
73+
platforms = (ANDROID, APPLE),
7774
deps = [
7875
"xplat//folly:molly",
7976
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/components/root/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,13 @@ rn_xplat_cxx_library(
3535
],
3636
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
3737
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
38-
fbobjc_tests = [
39-
":tests",
40-
],
4138
macosx_tests_override = [],
4239
platforms = (ANDROID, APPLE),
4340
preprocessor_flags = [
4441
"-DLOG_TAG=\"ReactNative\"",
4542
"-DWITH_FBSYSTRACE=1",
4643
],
47-
tests = [],
44+
tests = [":tests"],
4845
visibility = ["PUBLIC"],
4946
deps = [
5047
"xplat//fbsystrace:fbsystrace",
@@ -71,7 +68,7 @@ fb_xplat_cxx_test(
7168
"-Wall",
7269
],
7370
contacts = ["[email protected]"],
74-
platforms = APPLE,
71+
platforms = (ANDROID, APPLE),
7572
deps = [
7673
"xplat//folly:molly",
7774
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/components/scrollview/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ rn_xplat_cxx_library(
3838
],
3939
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4040
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
41-
fbobjc_tests = [
42-
":tests",
43-
],
4441
force_static = True,
4542
macosx_tests_override = [],
4643
platforms = (ANDROID, APPLE),
4744
preprocessor_flags = [
4845
"-DLOG_TAG=\"ReactNative\"",
4946
"-DWITH_FBSYSTRACE=1",
5047
],
51-
tests = [],
48+
tests = [":tests"],
5249
visibility = ["PUBLIC"],
5350
deps = [
5451
"xplat//fbsystrace:fbsystrace",
@@ -75,7 +72,7 @@ fb_xplat_cxx_test(
7572
"-Wall",
7673
],
7774
contacts = ["[email protected]"],
78-
platforms = APPLE,
75+
platforms = (ANDROID, APPLE),
7976
deps = [
8077
"xplat//folly:molly",
8178
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/components/slider/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,13 @@ rn_xplat_cxx_library(
3535
],
3636
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
3737
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
38-
fbobjc_tests = [
39-
":tests",
40-
],
4138
macosx_tests_override = [],
4239
platforms = (ANDROID, APPLE),
4340
preprocessor_flags = [
4441
"-DLOG_TAG=\"ReactNative\"",
4542
"-DWITH_FBSYSTRACE=1",
4643
],
47-
tests = [],
44+
tests = [":tests"],
4845
visibility = ["PUBLIC"],
4946
deps = [
5047
"xplat//fbsystrace:fbsystrace",
@@ -73,7 +70,7 @@ fb_xplat_cxx_test(
7370
"-Wall",
7471
],
7572
contacts = ["[email protected]"],
76-
platforms = APPLE,
73+
platforms = (ANDROID, APPLE),
7774
deps = [
7875
"xplat//folly:molly",
7976
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/components/text/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -42,17 +42,14 @@ rn_xplat_cxx_library(
4242
],
4343
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4444
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
45-
fbobjc_tests = [
46-
":tests",
47-
],
4845
force_static = True,
4946
macosx_tests_override = [],
5047
platforms = (ANDROID, APPLE),
5148
preprocessor_flags = [
5249
"-DLOG_TAG=\"ReactNative\"",
5350
"-DWITH_FBSYSTRACE=1",
5451
],
55-
tests = [],
52+
tests = [":tests"],
5653
visibility = ["PUBLIC"],
5754
deps = [
5855
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/components/view/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -41,17 +41,14 @@ rn_xplat_cxx_library(
4141
],
4242
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4343
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
44-
fbobjc_tests = [
45-
":tests",
46-
],
4744
force_static = True,
4845
macosx_tests_override = [],
4946
platforms = (ANDROID, APPLE),
5047
preprocessor_flags = [
5148
"-DLOG_TAG=\"ReactNative\"",
5249
"-DWITH_FBSYSTRACE=1",
5350
],
54-
tests = [],
51+
tests = [":tests"],
5552
visibility = ["PUBLIC"],
5653
deps = [
5754
"xplat//fbsystrace:fbsystrace",
@@ -77,7 +74,7 @@ fb_xplat_cxx_test(
7774
"-Wall",
7875
],
7976
contacts = ["[email protected]"],
80-
platforms = APPLE,
77+
platforms = (ANDROID, APPLE),
8178
deps = [
8279
"xplat//folly:molly",
8380
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/core/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,14 @@ rn_xplat_cxx_library(
3333
],
3434
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
3535
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
36-
fbobjc_tests = [
37-
":tests",
38-
],
3936
force_static = True,
4037
macosx_tests_override = [],
4138
platforms = (ANDROID, APPLE),
4239
preprocessor_flags = [
4340
"-DLOG_TAG=\"ReactNative\"",
4441
"-DWITH_FBSYSTRACE=1",
4542
],
46-
tests = [],
43+
tests = [":tests"],
4744
visibility = ["PUBLIC"],
4845
deps = [
4946
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/debug/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -40,17 +40,14 @@ rn_xplat_cxx_library(
4040
],
4141
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4242
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
43-
fbobjc_tests = [
44-
":tests",
45-
],
4643
force_static = True,
4744
macosx_tests_override = [],
4845
platforms = (ANDROID, APPLE),
4946
preprocessor_flags = [
5047
"-DLOG_TAG=\"ReactNative\"",
5148
"-DWITH_FBSYSTRACE=1",
5249
],
53-
tests = [],
50+
tests = [":tests"],
5451
visibility = ["PUBLIC"],
5552
deps = [
5653
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/events/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ rn_xplat_cxx_library(
3838
],
3939
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4040
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
41-
fbobjc_tests = [
42-
":tests",
43-
],
4441
force_static = True,
4542
macosx_tests_override = [],
4643
platforms = (ANDROID, APPLE),
4744
preprocessor_flags = [
4845
"-DLOG_TAG=\"ReactNative\"",
4946
"-DWITH_FBSYSTRACE=1",
5047
],
51-
tests = [],
48+
tests = [":tests"],
5249
visibility = ["PUBLIC"],
5350
deps = [
5451
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/graphics/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ rn_xplat_cxx_library(
5151
),
5252
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
5353
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
54-
fbobjc_tests = [
55-
":tests",
56-
],
5754
force_static = True,
5855
ios_deps = [
5956
"xplat//js:RCTImage",
@@ -82,7 +79,7 @@ rn_xplat_cxx_library(
8279
"-DLOG_TAG=\"ReactNative\"",
8380
"-DWITH_FBSYSTRACE=1",
8481
],
85-
tests = [],
82+
tests = [":tests"],
8683
visibility = ["PUBLIC"],
8784
deps = [
8885
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/imagemanager/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -48,9 +48,6 @@ rn_xplat_cxx_library(
4848
),
4949
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
5050
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
51-
fbobjc_tests = [
52-
":tests",
53-
],
5451
force_static = True,
5552
ios_deps = [
5653
"xplat//js:RCTImage",
@@ -87,7 +84,7 @@ rn_xplat_cxx_library(
8784
"-DLOG_TAG=\"ReactNative\"",
8885
"-DWITH_FBSYSTRACE=1",
8986
],
90-
tests = [],
87+
tests = [":tests"],
9188
visibility = ["PUBLIC"],
9289
deps = [
9390
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/mounting/BUCK

+1-4
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ rn_xplat_cxx_library(
3838
],
3939
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4040
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
41-
fbobjc_tests = [
42-
":tests",
43-
],
4441
force_static = True,
4542
macosx_tests_override = [],
4643
platforms = (ANDROID, APPLE),
4744
preprocessor_flags = [
4845
"-DLOG_TAG=\"ReactNative\"",
4946
"-DWITH_FBSYSTRACE=1",
5047
],
51-
tests = [],
48+
tests = [":tests"],
5249
visibility = ["PUBLIC"],
5350
deps = [
5451
"xplat//fbsystrace:fbsystrace",

‎ReactCommon/fabric/textlayoutmanager/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,6 @@ rn_xplat_cxx_library(
6363
),
6464
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
6565
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
66-
fbobjc_tests = [
67-
":tests",
68-
],
6966
force_static = True,
7067
ios_deps = [
7168
],
@@ -98,7 +95,7 @@ rn_xplat_cxx_library(
9895
"-DLOG_TAG=\"ReactNative\"",
9996
"-DWITH_FBSYSTRACE=1",
10097
],
101-
tests = [],
98+
tests = [":tests"],
10299
visibility = ["PUBLIC"],
103100
deps = [
104101
"xplat//fbsystrace:fbsystrace",
@@ -126,7 +123,7 @@ fb_xplat_cxx_test(
126123
"-Wall",
127124
],
128125
contacts = ["[email protected]"],
129-
platforms = APPLE,
126+
platforms = (ANDROID, APPLE),
130127
deps = [
131128
"xplat//folly:molly",
132129
"xplat//third-party/gmock:gtest",

‎ReactCommon/fabric/uimanager/BUCK

+2-5
Original file line numberDiff line numberDiff line change
@@ -38,17 +38,14 @@ rn_xplat_cxx_library(
3838
],
3939
fbobjc_compiler_flags = APPLE_COMPILER_FLAGS,
4040
fbobjc_preprocessor_flags = get_debug_preprocessor_flags() + get_apple_inspector_flags(),
41-
fbobjc_tests = [
42-
":uimanagertests",
43-
],
4441
force_static = True,
4542
macosx_tests_override = [],
4643
platforms = (ANDROID, APPLE),
4744
preprocessor_flags = [
4845
"-DLOG_TAG=\"ReactNative\"",
4946
"-DWITH_FBSYSTRACE=1",
5047
],
51-
tests = [],
48+
tests = [":tests"],
5249
visibility = ["PUBLIC"],
5350
deps = [
5451
"xplat//fbsystrace:fbsystrace",
@@ -69,7 +66,7 @@ rn_xplat_cxx_library(
6966
)
7067

7168
fb_xplat_cxx_test(
72-
name = "uimanagertests",
69+
name = "tests",
7370
srcs = glob(["tests/**/*.cpp"]),
7471
headers = glob(["tests/**/*.h"]),
7572
compiler_flags = [

0 commit comments

Comments
 (0)