Fix HMR syntax error messages (message instead of description)

ide · facebook-github-bot · commit 2b80cdf1bba3 · 2018-01-16T03:42:44.000-08:00
Summary: The code to display HMR errors on the client was reading the `description` field from Metro payloads. Metro does not include `description` in the body of its error payloads -- only in its `body.errors[]` items. This commit changes RN's HMR code to show `body.message` (set consistently with facebook/metro#124) instead of the non-existent `body.description`. Open a test RN app, enable HMR, and then introduce a syntax error in an app source file. See that the redbox provides information about the syntax error instead of just saying "TransformError undefined". - facebook/metro#124 [GENERAL][ENHANCEMENT][HMR] - Fix display of syntax error messages when HMR is enabled Closes #17619 Differential Revision: D6726516 Pulled By: mjesun fbshipit-source-id: b1d1008d6f1aa8f88ff8a2aa1374724a305c773b
diff --git a/Libraries/Utilities/HMRClient.js b/Libraries/Utilities/HMRClient.js
@@ -121,7 +121,7 @@ Error: ${e.message}`
         }
         case 'error': {
           HMRLoadingView.hide();
-          throw new Error(data.body.type + ' ' + data.body.description);
+          throw new Error(`${data.body.type}: ${data.body.message}`);
         }
         default: {
           throw new Error(`Unexpected message: ${data}`);

Original file line number	Diff line number	Diff line change
@@ -121,7 +121,7 @@ Error: ${e.message}`
`121`	`121`	`}`
`122`	`122`	`case 'error': {`
`123`	`123`	`HMRLoadingView.hide();`
`124`		`- throw new Error(data.body.type + ' ' + data.body.description);`
	`124`	+ throw new Error(`${data.body.type}: ${data.body.message}`);
`125`	`125`	`}`
`126`	`126`	`default: {`
`127`	`127`	throw new Error(`Unexpected message: ${data}`);