Skip to content

Commit 2f1421d

Browse files
mistenktfacebook-github-bot
authored andcommitted
Fix for scrollview android
Summary: Trying this again with a fresh pullrequest as the old one kept having issued due to rebasing. Fixes #16635 the issue is a little serious if you use a scrollview which contains textinput, you will never get a chance to input something since keyboard will always be dismissed because of on-drag event if your scroll-view use the property: keyboardDismissMode ='on-drag' verify the issue #16635 and tested this fix worked [ANDROID] [BUGFIX] [ScrollView] - Check that isTouching is also set when dismissing keyboard with on-drag android. Closes #18785 Differential Revision: D7569815 Pulled By: hramos fbshipit-source-id: 2a07369297ce9ce5a7714e513ccb480ee7011a4d
1 parent b4c7136 commit 2f1421d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Libraries/Components/ScrollView/ScrollView.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ const ScrollView = createReactClass({
681681
}
682682
}
683683
if (Platform.OS === 'android') {
684-
if (this.props.keyboardDismissMode === 'on-drag') {
684+
if (this.props.keyboardDismissMode === 'on-drag' && this.state.isTouching) {
685685
dismissKeyboard();
686686
}
687687
}

0 commit comments

Comments
 (0)