Skip to content

Commit 2fef1ba

Browse files
hovoxfacebook-github-bot
authored andcommitted
GLog fix on case sensitive APFS macOS
Summary: <!-- Thank you for sending the PR! We appreciate you spending the time to work on these changes. Help us understand your motivation by explaining why you decided to make this change. You can learn more about contributing to React Native here: http://facebook.github.io/react-native/docs/contributing.html Happy contributing! --> This will fix compile error on case sensitive APFS(Apple File System) macs. Integrate RN on case sensitive formatted macOS via cocoa pods you will get compile errors on the include lines something like : ``` ^~~~~~~~~~~~~~~~ 1 error generated. ** BUILD FAILED ** ``` If you change `#include <glog/logging.h>` into `#include <GLog/logging.h>` (replace `glog` with `GLog`) it will fix the build error. After fixing this you will get same kind of errors on a few other places. [IOS] [BUGFIX] [Framework] - `GLog` fix on case sensitive APFS macOS Closes #17697 Differential Revision: D6832740 Pulled By: shergin fbshipit-source-id: 0c7a01f33fde35dbc8004c5bb6e5b22f8f0ea369
1 parent be7037f commit 2fef1ba

File tree

3 files changed

+3
-3
lines changed

3 files changed

+3
-3
lines changed

scripts/process-podspecs.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ process() {
6565
cd "$ROOT/third-party-podspecs"
6666
push Folly.podspec
6767
push DoubleConversion.podspec
68-
push GLog.podspec
68+
push glog.podspec
6969

7070
process "$ROOT/ReactCommon/yoga"
7171
process "$ROOT" _ignore_me_subspec_for_linting_

third-party-podspecs/Folly.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ Pod::Spec.new do |spec|
1010
spec.module_name = 'folly'
1111
spec.dependency 'boost-for-react-native'
1212
spec.dependency 'DoubleConversion'
13-
spec.dependency 'GLog'
13+
spec.dependency 'glog'
1414
spec.compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1'
1515
spec.source_files = 'folly/Bits.cpp',
1616
'folly/Conv.cpp',

third-party-podspecs/GLog.podspec third-party-podspecs/glog.podspec

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
Pod::Spec.new do |spec|
2-
spec.name = 'GLog'
2+
spec.name = 'glog'
33
spec.version = '0.3.4'
44
spec.license = { :type => 'Google', :file => 'COPYING' }
55
spec.homepage = 'https://github.com/google/glog'

0 commit comments

Comments
 (0)