Skip to content

Commit 3b9604f

Browse files
dulmandakhfacebook-github-bot
authored andcommitted
ReactActivity extends AppCompatActivity (#23278)
Summary: Google recommends to extend AppCompatActivity. and This PR changes ReactActivity to extend AppCompatActivity [Android] [Changed] - ReactActivity extends AppCompatActivity Pull Request resolved: #23278 Reviewed By: fkgozali Differential Revision: D13937917 Pulled By: mdvacca fbshipit-source-id: 4216482b30349b24e3cbf2bdc24d9a890744132f
1 parent d53dbb0 commit 3b9604f

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ReactAndroid/src/main/java/com/facebook/react/BUCK

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ rn_android_library(
44
name = "react",
55
srcs = glob(["*.java"]),
66
provided_deps = [
7+
react_native_dep("third-party/android/support/v7/appcompat-orig:appcompat"),
78
react_native_dep("third-party/android/support/v4:lib-support-v4"),
8-
react_native_dep("third-party/android/support-annotations:android-support-annotations"),
99
],
1010
visibility = [
1111
"PUBLIC",

ReactAndroid/src/main/java/com/facebook/react/ReactActivity.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
import android.content.Intent;
1313
import android.os.Bundle;
14-
import android.support.v4.app.FragmentActivity;
14+
import android.support.v7.app.AppCompatActivity;
1515
import android.view.KeyEvent;
1616

1717
import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
@@ -21,7 +21,7 @@
2121
/**
2222
* Base Activity for React Native applications.
2323
*/
24-
public abstract class ReactActivity extends FragmentActivity
24+
public abstract class ReactActivity extends AppCompatActivity
2525
implements DefaultHardwareBackBtnHandler, PermissionAwareActivity {
2626

2727
private final ReactActivityDelegate mDelegate;

0 commit comments

Comments
 (0)