resizeMode applies to Image.defaultSource (#22216)

dulmandakh · facebook-github-bot · commit 673ef39561ce · 2018-11-15T20:37:16.000-08:00
Summary: resizeMode applies to Image.defaultSource, because depending on screen resolution sometimes we see padding around defaultSource image while source loading. Now we can control scale of both source and defaultSource. Changelog: ---------- [Android] [Fixed] - Image.resizeMode will apply to defaultSource, enhanced user experience. Previously, resizeMode didn't applied to defaultSource, therefore depending on screen resolution sometimes we see padding around defaultSource image while source loading. Pull Request resolved: #22216 Differential Revision: D13088220 Pulled By: mdvacca fbshipit-source-id: 92c66cf6228f3b7666b9ef2404d034f0005b5234
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java b/ReactAndroid/src/main/java/com/facebook/react/views/image/ReactImageView.java
@@ -439,7 +439,7 @@ public void maybeUpdateView() {
     hierarchy.setActualImageScaleType(mScaleType);
 
     if (mDefaultImageDrawable != null) {
-      hierarchy.setPlaceholderImage(mDefaultImageDrawable, ScalingUtils.ScaleType.CENTER);
+      hierarchy.setPlaceholderImage(mDefaultImageDrawable, mScaleType);
     }
 
     if (mLoadingImageDrawable != null) {

Original file line number	Diff line number	Diff line change
`@@ -439,7 +439,7 @@ public void maybeUpdateView() {`
`439`	`439`	`hierarchy.setActualImageScaleType(mScaleType);`
`440`	`440`
`441`	`441`	`if (mDefaultImageDrawable != null) {`
`442`		`- hierarchy.setPlaceholderImage(mDefaultImageDrawable, ScalingUtils.ScaleType.CENTER);`
	`442`	`+ hierarchy.setPlaceholderImage(mDefaultImageDrawable, mScaleType);`
`443`	`443`	`}`
`444`	`444`
`445`	`445`	`if (mLoadingImageDrawable != null) {`