Skip to content

Commit 6b07602

Browse files
liangtongchuanfacebook-github-bot
liangtongchuan
authored andcommitted
Update fresco to v1.9.0, okhttp3 to v3.10.0
Summary: I found many crash reports of imagepipeline in our android app, this is caused by fresco webp native memory leak, they have fixed it in v1.9.0 fixed wrong pull request of [18848](#18848) Test with local build. Check CI passes. [ANDROID] [ENHANCEMENT] [Fresco/OkHttp] - Updates Fresco to 1.9.0, OkHttp to 3.10.0 Closes #18849 Differential Revision: D7651377 Pulled By: mdvacca fbshipit-source-id: 0bfe79fd3d232b11a6a9380c961b9401c9e0ced9
1 parent 9909a42 commit 6b07602

File tree

3 files changed

+20
-20
lines changed

3 files changed

+20
-20
lines changed

ReactAndroid/build.gradle

+4-4
Original file line numberDiff line numberDiff line change
@@ -294,12 +294,12 @@ dependencies {
294294
compile 'javax.inject:javax.inject:1'
295295
compile 'com.android.support:appcompat-v7:23.0.1'
296296
compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'
297-
compile 'com.facebook.fresco:fresco:1.8.1'
298-
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.8.1'
297+
compile 'com.facebook.fresco:fresco:1.9.0'
298+
compile 'com.facebook.fresco:imagepipeline-okhttp3:1.9.0'
299299
compile 'com.facebook.soloader:soloader:0.3.0'
300300
compile 'com.google.code.findbugs:jsr305:3.0.0'
301-
compile 'com.squareup.okhttp3:okhttp:3.8.0'
302-
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.8.0'
301+
compile 'com.squareup.okhttp3:okhttp:3.10.0'
302+
compile 'com.squareup.okhttp3:okhttp-urlconnection:3.10.0'
303303
compile 'com.squareup.okio:okio:1.14.0'
304304
compile 'org.webkit:android-jsc:r174650'
305305

ReactAndroid/src/main/libraries/fresco/fresco-react-native/BUCK

+12-12
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ rn_android_prebuilt_aar(
88

99
remote_file(
1010
name = "fresco-binary-aar",
11-
sha1 = "c6ed3f696ed47dca3b20d4ffbd0600c94b9119b2",
12-
url = "mvn:com.facebook.fresco:fresco:aar:1.8.1",
11+
sha1 = "f4415e8676eef4d12fdc8ddbd784bb752cf0c5e3",
12+
url = "mvn:com.facebook.fresco:fresco:aar:1.9.0",
1313
)
1414

1515
android_prebuilt_aar(
@@ -20,8 +20,8 @@ android_prebuilt_aar(
2020

2121
remote_file(
2222
name = "drawee-binary-aar",
23-
sha1 = "6bc689901ddcac8f3df5ba4db1f8aabeb8e80107",
24-
url = "mvn:com.facebook.fresco:drawee:aar:1.8.1",
23+
sha1 = "e0c3b0fa64fc7525f05a852476bc8723ae6ddc90",
24+
url = "mvn:com.facebook.fresco:drawee:aar:1.9.0",
2525
)
2626

2727
rn_android_library(
@@ -42,8 +42,8 @@ rn_android_prebuilt_aar(
4242

4343
remote_file(
4444
name = "imagepipeline-base-aar",
45-
sha1 = "42fd80c46a853850dfc0d71808b982fef401c841",
46-
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.8.1",
45+
sha1 = "8034e5c8a75385bd20e72ff51489b0673029fcf7",
46+
url = "mvn:com.facebook.fresco:imagepipeline-base:aar:1.9.0",
4747
)
4848

4949
rn_android_prebuilt_aar(
@@ -54,8 +54,8 @@ rn_android_prebuilt_aar(
5454

5555
remote_file(
5656
name = "imagepipeline-aar",
57-
sha1 = "06a2a4c3e1d9a7fb7d7f1ad14db63e2d32ef0b61",
58-
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.8.1",
57+
sha1 = "8043733b1bf3713d3a3c7fc7896205c96c050fd7",
58+
url = "mvn:com.facebook.fresco:imagepipeline:aar:1.9.0",
5959
)
6060

6161
rn_prebuilt_jar(
@@ -78,8 +78,8 @@ android_prebuilt_aar(
7878

7979
remote_file(
8080
name = "fbcore-aar",
81-
sha1 = "99b7a83946e16f037149e4cd3abfd6840a09445d",
82-
url = "mvn:com.facebook.fresco:fbcore:aar:1.8.1",
81+
sha1 = "fc3703511dc7b135bcd0e76d8015cdaf247b1760",
82+
url = "mvn:com.facebook.fresco:fbcore:aar:1.9.0",
8383
)
8484

8585
android_prebuilt_aar(
@@ -90,6 +90,6 @@ android_prebuilt_aar(
9090

9191
remote_file(
9292
name = "imagepipeline-okhttp3-binary-aar",
93-
sha1 = "751f19412e1843b1c1e76eae46e388fb1deddbcc",
94-
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.8.1",
93+
sha1 = "4ac95941c1761a1ba5647ed551f7e47a5c417c7b",
94+
url = "mvn:com.facebook.fresco:imagepipeline-okhttp3:aar:1.9.0",
9595
)

ReactAndroid/src/main/third-party/java/okhttp/BUCK

+4-4
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@ prebuilt_jar(
66

77
remote_file(
88
name = "okhttp3-binary-jar",
9-
sha1 = "5a11f020cce2d11eb71ba916700600e18c4547e7",
10-
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.8.0",
9+
sha1 = "7ef0f1d95bf4c0b3ba30bbae25e0e562b05cf75e",
10+
url = "mvn:com.squareup.okhttp3:okhttp:jar:3.10.0",
1111
)
1212

1313
prebuilt_jar(
@@ -18,6 +18,6 @@ prebuilt_jar(
1818

1919
remote_file(
2020
name = "okhttp3-urlconnection-binary-jar",
21-
sha1 = "265257b82f20bb0371a926cc8ceb5f7bb17c0df8",
22-
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.8.0",
21+
sha1 = "ec614c05825ddd2267677a99f585d3913474b125",
22+
url = "mvn:com.squareup.okhttp3:okhttp-urlconnection:jar:3.10.0",
2323
)

0 commit comments

Comments
 (0)