Stops endless logging by packager client for debug builds that use static bundles. (#24050)

deadwater88 · facebook-github-bot · commit 7fce997ea5bd · 2019-03-20T10:59:30.000-07:00
Summary: For the use-case where iOSdebug builds prefer to use static bundles over bundles served dynamically by metro. There's currently a bug caused by the packager client repeatedly attempting to connect to metro. This leads to endless log statements in xcode as well as other side effects: #21030. Fix is based off of #21030 which fixes the behavior for the inspector. Stops endless logging by packager client for debug builds that use static bundles. [CATEGORY] [TYPE] - Message Pull Request resolved: #24050 Differential Revision: D14541574 Pulled By: cpojer fbshipit-source-id: 09c2c82eb2d4aeb0e7ba322fd81b0dd7bf9e683c
diff --git a/Libraries/WebSocket/RCTReconnectingWebSocket.m b/Libraries/WebSocket/RCTReconnectingWebSocket.m
@@ -163,7 +163,9 @@ - (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket
 - (void)webSocket:(RCTSRWebSocket *)webSocket didFailWithError:(NSError *)error
 {
   [_delegate reconnectingWebSocketDidClose:self];
-  [self reconnect];
+  if ([error code] != ECONNREFUSED) {
+    [self reconnect];
+  }
 }
 
 - (void)webSocket:(RCTSRWebSocket *)webSocket didCloseWithCode:(NSInteger)code reason:(NSString *)reason wasClean:(BOOL)wasClean

Original file line number	Diff line number	Diff line change
`@@ -163,7 +163,9 @@ - (void)webSocketDidOpen:(RCTSRWebSocket *)webSocket`
`163`	`163`	`- (void)webSocket:(RCTSRWebSocket )webSocket didFailWithError:(NSError )error`
`164`	`164`	`{`
`165`	`165`	`[_delegate reconnectingWebSocketDidClose:self];`
`166`		`- [self reconnect];`
	`166`	`+ if ([error code] != ECONNREFUSED) {`
	`167`	`+ [self reconnect];`
	`168`	`+ }`
`167`	`169`	`}`
`168`	`170`
`169`	`171`	`- (void)webSocket:(RCTSRWebSocket )webSocket didCloseWithCode:(NSInteger)code reason:(NSString )reason wasClean:(BOOL)wasClean`