Skip to content

Commit 80f92ad

Browse files
fkgozalifacebook-github-bot
authored andcommittedNov 9, 2018
iOS: ignore double registration of lazy modules with chrome attached
Summary: Depending on when Chrome debugger is attached, modules may get double registered. Simply ignore it for this case. The redbox was not a fatal error, which can be dismissed. Reviewed By: shergin Differential Revision: D12996107 fbshipit-source-id: 292f63102337077848842ca46b3daed08b1cae12
1 parent d7865eb commit 80f92ad

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed
 

‎React/CxxBridge/RCTCxxBridge.mm

+2-4
Original file line numberDiff line numberDiff line change
@@ -666,10 +666,8 @@ - (void)registerExtraLazyModules
666666
// The new module returned nil from init, so use the old module
667667
continue;
668668
} else if ([moduleData.moduleClass new] != nil) {
669-
// Both modules were non-nil, so it's unclear which should take precedence
670-
RCTLogError(@"Attempted to register RCTBridgeModule class %@ for the "
671-
"name '%@', but name was already registered by class %@",
672-
moduleClass, moduleName, moduleData.moduleClass);
669+
// Use existing module since it was already loaded but not yet instantiated.
670+
continue;
673671
}
674672
}
675673

0 commit comments

Comments
 (0)
Please sign in to comment.