Skip to content

Commit 850efa8

Browse files
bnhamfacebook-github-bot
authored andcommitted
remove hard dependency on JSGlobalContextRef in inspector interfaces
Differential Revision: D6385923 fbshipit-source-id: 2f547b0dc1760f72fa8d7edc67327415069c648e
1 parent 5f99b1a commit 850efa8

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

ReactCommon/jschelpers/InspectorInterfaces.h

+2-4
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
#include <string>
1515
#include <vector>
1616

17-
#include <JavaScriptCore/JSBase.h>
18-
1917
namespace facebook {
2018
namespace react {
2119

@@ -46,8 +44,8 @@ class ILocalConnection : public IDestructible {
4644
// Note: not destructible!
4745
class IInspector {
4846
public:
49-
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, JSGlobalContextRef ctx) = 0;
50-
virtual void unregisterGlobalContext(JSGlobalContextRef ctx) = 0;
47+
virtual void registerGlobalContext(const std::string& title, const std::function<bool()> &checkIsInspectedRemote, void* ctx) = 0;
48+
virtual void unregisterGlobalContext(void* ctx) = 0;
5149

5250
virtual std::vector<InspectorPage> getPages() const = 0;
5351
virtual std::unique_ptr<ILocalConnection> connect(int pageId, std::unique_ptr<IRemoteConnection> remote) = 0;

0 commit comments

Comments
 (0)