Skip to content

Commit 85503a0

Browse files
sherginfacebook-github-bot
authored andcommitted
Fixed retain cycle in RCTFBHTTPRequestHandler
Summary: Following common ObjC pattern, we have to store delegates as weak pointers. Reviewed By: mmmulani Differential Revision: D6558886 fbshipit-source-id: 11a710a7e9e17d7c6a78ae46b53b043f44ccf8e5
1 parent 71751e9 commit 85503a0

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

React/Base/RCTURLRequestHandler.h

+1
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
* itself. This will be used later to refer to the request in callbacks. The
3030
* `sendRequest:withDelegate:` method *must* return before calling any of the
3131
* delegate methods, or the delegate won't recognize the token.
32+
* Following common Objective-C pattern, `delegate` will not be retained.
3233
*/
3334
- (id)sendRequest:(NSURLRequest *)request
3435
withDelegate:(id<RCTURLRequestDelegate>)delegate;

0 commit comments

Comments
 (0)