Skip to content

Commit 8da1f11

Browse files
Daniel Sainatifacebook-github-bot
Daniel Sainati
authored and
facebook-github-bot
committed
deploy 0.93
Summary: upgrades flow version allow-large-files bypass-lint Reviewed By: nmote Differential Revision: D14095305 fbshipit-source-id: 000b3b2e085f673bc443fc8bc1b3aae1b42df0e9
1 parent cbf65f2 commit 8da1f11

13 files changed

+8
-141
lines changed

‎.flowconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ untyped-import
9898
untyped-type-import
9999

100100
[version]
101-
^0.92.0
101+
^0.93.0

‎.flowconfig.android

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,4 +98,4 @@ untyped-import
9898
untyped-type-import
9999

100100
[version]
101-
^0.92.0
101+
^0.93.0

‎Libraries/Components/TextInput/TextInput.js

-3
Original file line numberDiff line numberDiff line change
@@ -1161,9 +1161,6 @@ const TextInput = createReactClass({
11611161
props.autoCapitalize = UIManager.getViewManagerConfig(
11621162
'AndroidTextInput',
11631163
).Constants.AutoCapitalizationType[props.autoCapitalize || 'sentences'];
1164-
/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This comment
1165-
* suppresses an error when upgrading Flow's support for React. To see the
1166-
* error delete this comment and run Flow. */
11671164
let children = this.props.children;
11681165
let childCount = 0;
11691166
React.Children.forEach(children, () => ++childCount);

‎Libraries/Components/Touchable/TouchableBounce.js

-21
Original file line numberDiff line numberDiff line change
@@ -89,9 +89,6 @@ const TouchableBounce = ((createReactClass({
8989

9090
getInitialState: function(): State {
9191
return {
92-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
93-
* error found when Flow v0.89 was deployed. To see the error, delete
94-
* this comment and run Flow. */
9592
...this.touchableGetInitialState(),
9693
scale: new Animated.Value(1),
9794
};
@@ -187,31 +184,13 @@ const TouchableBounce = ((createReactClass({
187184
nativeID={this.props.nativeID}
188185
testID={this.props.testID}
189186
hitSlop={this.props.hitSlop}
190-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
191-
* error found when Flow v0.89 was deployed. To see the error, delete
192-
* this comment and run Flow. */
193187
onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
194188
onResponderTerminationRequest={
195-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses
196-
* an error found when Flow v0.89 was deployed. To see the error,
197-
* delete this comment and run Flow. */
198189
this.touchableHandleResponderTerminationRequest
199190
}
200-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
201-
* error found when Flow v0.89 was deployed. To see the error, delete
202-
* this comment and run Flow. */
203191
onResponderGrant={this.touchableHandleResponderGrant}
204-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
205-
* error found when Flow v0.89 was deployed. To see the error, delete
206-
* this comment and run Flow. */
207192
onResponderMove={this.touchableHandleResponderMove}
208-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
209-
* error found when Flow v0.89 was deployed. To see the error, delete
210-
* this comment and run Flow. */
211193
onResponderRelease={this.touchableHandleResponderRelease}
212-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
213-
* error found when Flow v0.89 was deployed. To see the error, delete
214-
* this comment and run Flow. */
215194
onResponderTerminate={this.touchableHandleResponderTerminate}>
216195
{this.props.children}
217196
{Touchable.renderDebugView({

‎Libraries/Components/Touchable/TouchableHighlight.js

-60
Original file line numberDiff line numberDiff line change
@@ -203,15 +203,9 @@ const TouchableHighlight = ((createReactClass({
203203
getDefaultProps: () => DEFAULT_PROPS,
204204

205205
getInitialState: function() {
206-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
207-
* error found when Flow v0.89 was deployed. To see the error, delete this
208-
* comment and run Flow. */
209206
this._isMounted = false;
210207
if (this.props.testOnly_pressed) {
211208
return {
212-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
213-
* error found when Flow v0.89 was deployed. To see the error, delete
214-
* this comment and run Flow. */
215209
...this.touchableGetInitialState(),
216210
extraChildStyle: {
217211
opacity: this.props.activeOpacity,
@@ -222,9 +216,6 @@ const TouchableHighlight = ((createReactClass({
222216
};
223217
} else {
224218
return {
225-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
226-
* error found when Flow v0.89 was deployed. To see the error, delete
227-
* this comment and run Flow. */
228219
...this.touchableGetInitialState(),
229220
extraChildStyle: null,
230221
extraUnderlayStyle: null,
@@ -233,21 +224,12 @@ const TouchableHighlight = ((createReactClass({
233224
},
234225

235226
componentDidMount: function() {
236-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
237-
* error found when Flow v0.89 was deployed. To see the error, delete this
238-
* comment and run Flow. */
239227
this._isMounted = true;
240228
ensurePositiveDelayProps(this.props);
241229
},
242230

243231
componentWillUnmount: function() {
244-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
245-
* error found when Flow v0.89 was deployed. To see the error, delete this
246-
* comment and run Flow. */
247232
this._isMounted = false;
248-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
249-
* error found when Flow v0.89 was deployed. To see the error, delete this
250-
* comment and run Flow. */
251233
clearTimeout(this._hideTimeout);
252234
},
253235

@@ -265,22 +247,13 @@ const TouchableHighlight = ((createReactClass({
265247
* defined on your component.
266248
*/
267249
touchableHandleActivePressIn: function(e: PressEvent) {
268-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
269-
* error found when Flow v0.89 was deployed. To see the error, delete this
270-
* comment and run Flow. */
271250
clearTimeout(this._hideTimeout);
272-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
273-
* error found when Flow v0.89 was deployed. To see the error, delete this
274-
* comment and run Flow. */
275251
this._hideTimeout = null;
276252
this._showUnderlay();
277253
this.props.onPressIn && this.props.onPressIn(e);
278254
},
279255

280256
touchableHandleActivePressOut: function(e: PressEvent) {
281-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
282-
* error found when Flow v0.89 was deployed. To see the error, delete this
283-
* comment and run Flow. */
284257
if (!this._hideTimeout) {
285258
this._hideUnderlay();
286259
}
@@ -302,15 +275,9 @@ const TouchableHighlight = ((createReactClass({
302275
},
303276

304277
touchableHandlePress: function(e: PressEvent) {
305-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
306-
* error found when Flow v0.89 was deployed. To see the error, delete this
307-
* comment and run Flow. */
308278
clearTimeout(this._hideTimeout);
309279
if (!Platform.isTV) {
310280
this._showUnderlay();
311-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
312-
* error found when Flow v0.89 was deployed. To see the error, delete
313-
* this comment and run Flow. */
314281
this._hideTimeout = setTimeout(
315282
this._hideUnderlay,
316283
this.props.delayPressOut,
@@ -344,9 +311,6 @@ const TouchableHighlight = ((createReactClass({
344311
},
345312

346313
_showUnderlay: function() {
347-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
348-
* error found when Flow v0.89 was deployed. To see the error, delete this
349-
* comment and run Flow. */
350314
if (!this._isMounted || !this._hasPressHandler()) {
351315
return;
352316
}
@@ -362,13 +326,7 @@ const TouchableHighlight = ((createReactClass({
362326
},
363327

364328
_hideUnderlay: function() {
365-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
366-
* error found when Flow v0.89 was deployed. To see the error, delete this
367-
* comment and run Flow. */
368329
clearTimeout(this._hideTimeout);
369-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
370-
* error found when Flow v0.89 was deployed. To see the error, delete this
371-
* comment and run Flow. */
372330
this._hideTimeout = null;
373331
if (this.props.testOnly_pressed) {
374332
return;
@@ -409,31 +367,13 @@ const TouchableHighlight = ((createReactClass({
409367
isTVSelectable={true}
410368
tvParallaxProperties={this.props.tvParallaxProperties}
411369
hasTVPreferredFocus={this.props.hasTVPreferredFocus}
412-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
413-
* error found when Flow v0.89 was deployed. To see the error, delete
414-
* this comment and run Flow. */
415370
onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
416371
onResponderTerminationRequest={
417-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses
418-
* an error found when Flow v0.89 was deployed. To see the error,
419-
* delete this comment and run Flow. */
420372
this.touchableHandleResponderTerminationRequest
421373
}
422-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
423-
* error found when Flow v0.89 was deployed. To see the error, delete
424-
* this comment and run Flow. */
425374
onResponderGrant={this.touchableHandleResponderGrant}
426-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
427-
* error found when Flow v0.89 was deployed. To see the error, delete
428-
* this comment and run Flow. */
429375
onResponderMove={this.touchableHandleResponderMove}
430-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
431-
* error found when Flow v0.89 was deployed. To see the error, delete
432-
* this comment and run Flow. */
433376
onResponderRelease={this.touchableHandleResponderRelease}
434-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
435-
* error found when Flow v0.89 was deployed. To see the error, delete
436-
* this comment and run Flow. */
437377
onResponderTerminate={this.touchableHandleResponderTerminate}
438378
nativeID={this.props.nativeID}
439379
testID={this.props.testID}>

‎Libraries/Components/Touchable/TouchableOpacity.js

-27
Original file line numberDiff line numberDiff line change
@@ -162,13 +162,7 @@ const TouchableOpacity = ((createReactClass({
162162

163163
getInitialState: function() {
164164
return {
165-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
166-
* error found when Flow v0.89 was deployed. To see the error, delete
167-
* this comment and run Flow. */
168165
...this.touchableGetInitialState(),
169-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
170-
* error found when Flow v0.89 was deployed. To see the error, delete
171-
* this comment and run Flow. */
172166
anim: new Animated.Value(this._getChildStyleOpacityWithDefault()),
173167
};
174168
},
@@ -266,9 +260,6 @@ const TouchableOpacity = ((createReactClass({
266260
},
267261

268262
_opacityInactive: function(duration: number) {
269-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
270-
* error found when Flow v0.89 was deployed. To see the error, delete this
271-
* comment and run Flow. */
272263
this.setOpacityTo(this._getChildStyleOpacityWithDefault(), duration);
273264
},
274265

@@ -293,31 +284,13 @@ const TouchableOpacity = ((createReactClass({
293284
hasTVPreferredFocus={this.props.hasTVPreferredFocus}
294285
tvParallaxProperties={this.props.tvParallaxProperties}
295286
hitSlop={this.props.hitSlop}
296-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
297-
* error found when Flow v0.89 was deployed. To see the error, delete
298-
* this comment and run Flow. */
299287
onStartShouldSetResponder={this.touchableHandleStartShouldSetResponder}
300288
onResponderTerminationRequest={
301-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses
302-
* an error found when Flow v0.89 was deployed. To see the error,
303-
* delete this comment and run Flow. */
304289
this.touchableHandleResponderTerminationRequest
305290
}
306-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
307-
* error found when Flow v0.89 was deployed. To see the error, delete
308-
* this comment and run Flow. */
309291
onResponderGrant={this.touchableHandleResponderGrant}
310-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
311-
* error found when Flow v0.89 was deployed. To see the error, delete
312-
* this comment and run Flow. */
313292
onResponderMove={this.touchableHandleResponderMove}
314-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
315-
* error found when Flow v0.89 was deployed. To see the error, delete
316-
* this comment and run Flow. */
317293
onResponderRelease={this.touchableHandleResponderRelease}
318-
/* $FlowFixMe(>=0.89.0 site=react_native_fb) This comment suppresses an
319-
* error found when Flow v0.89 was deployed. To see the error, delete
320-
* this comment and run Flow. */
321294
onResponderTerminate={this.touchableHandleResponderTerminate}>
322295
{this.props.children}
323296
{Touchable.renderDebugView({

‎Libraries/Core/Timers/JSTimers.js

-9
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,6 @@ const JSTimers = {
290290
* @param {function} func Callback to be invoked before the end of the
291291
* current JavaScript execution loop.
292292
*/
293-
/* $FlowFixMe(>=0.79.1 site=react_native_fb) This comment suppresses an
294-
* error found when Flow v0.79 was deployed. To see the error delete this
295-
* comment and run Flow. */
296293
setImmediate: function(func: Function, ...args: any) {
297294
const id = _allocateCallback(
298295
() => func.apply(undefined, args),
@@ -305,9 +302,6 @@ const JSTimers = {
305302
/**
306303
* @param {function} func Callback to be invoked every frame.
307304
*/
308-
/* $FlowFixMe(>=0.79.1 site=react_native_fb) This comment suppresses an
309-
* error found when Flow v0.79 was deployed. To see the error delete this
310-
* comment and run Flow. */
311305
requestAnimationFrame: function(func: Function) {
312306
const id = _allocateCallback(func, 'requestAnimationFrame');
313307
Timing.createTimer(id, 1, Date.now(), /* recurring */ false);
@@ -319,9 +313,6 @@ const JSTimers = {
319313
* with time remaining in frame.
320314
* @param {?object} options
321315
*/
322-
/* $FlowFixMe(>=0.79.1 site=react_native_fb) This comment suppresses an
323-
* error found when Flow v0.79 was deployed. To see the error delete this
324-
* comment and run Flow. */
325316
requestIdleCallback: function(func: Function, options: ?Object) {
326317
if (requestIdleCallbacks.length === 0) {
327318
Timing.setSendIdleEvents(true);

‎Libraries/Lists/ListView/InternalListViewType.js

-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ class InternalListViewType<Props> extends React.Component<Props> {
2121
flashScrollIndicators() {}
2222
getScrollResponder(): any {}
2323
getScrollableNode(): any {}
24-
// $FlowFixMe
2524
getMetrics(): Object {}
2625
scrollTo(...args: Array<mixed>) {}
2726
scrollToEnd(options?: ?{animated?: ?boolean}) {}

‎Libraries/Lists/VirtualizedList.js

-9
Original file line numberDiff line numberDiff line change
@@ -290,9 +290,6 @@ class VirtualizedList extends React.PureComponent<Props, State> {
290290
* suppresses an error when upgrading Flow's support for React. To see the
291291
* error delete this comment and run Flow. */
292292
this._scrollRef.scrollTo(
293-
/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This
294-
* comment suppresses an error when upgrading Flow's support for React.
295-
* To see the error delete this comment and run Flow. */
296293
this.props.horizontal ? {x: offset, animated} : {y: offset, animated},
297294
);
298295
}
@@ -341,9 +338,6 @@ class VirtualizedList extends React.PureComponent<Props, State> {
341338
* suppresses an error when upgrading Flow's support for React. To see the
342339
* error delete this comment and run Flow. */
343340
this._scrollRef.scrollTo(
344-
/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This
345-
* comment suppresses an error when upgrading Flow's support for React.
346-
* To see the error delete this comment and run Flow. */
347341
horizontal ? {x: offset, animated} : {y: offset, animated},
348342
);
349343
}
@@ -382,9 +376,6 @@ class VirtualizedList extends React.PureComponent<Props, State> {
382376
* suppresses an error when upgrading Flow's support for React. To see the
383377
* error delete this comment and run Flow. */
384378
this._scrollRef.scrollTo(
385-
/* $FlowFixMe(>=0.53.0 site=react_native_fb,react_native_oss) This
386-
* comment suppresses an error when upgrading Flow's support for React.
387-
* To see the error delete this comment and run Flow. */
388379
this.props.horizontal ? {x: offset, animated} : {y: offset, animated},
389380
);
390381
}

‎RNTester/js/ScrollViewSimpleExample.js

-3
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@ const {ScrollView, StyleSheet, Text, TouchableOpacity} = ReactNative;
1717
const NUM_ITEMS = 20;
1818

1919
class ScrollViewSimpleExample extends React.Component<{}> {
20-
/* $FlowFixMe(>=0.85.0 site=react_native_fb) This comment suppresses an error
21-
* found when Flow v0.85 was deployed. To see the error, delete this comment
22-
* and run Flow. */
2320
makeItems = (nItems: number, styles): Array<any> => {
2421
const items = [];
2522
for (let i = 0; i < nItems; i++) {

‎package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@
200200
"eslint-plugin-react": "7.8.2",
201201
"eslint-plugin-react-hooks": "^1.0.1",
202202
"eslint-plugin-react-native": "3.5.0",
203-
"flow-bin": "^0.92.0",
203+
"flow-bin": "^0.93.0",
204204
"jest": "24.0.0-alpha.6",
205205
"jest-junit": "6.3.0",
206206
"jscodeshift": "^0.6.2",

‎template/_flowconfig

+1-1
Original file line numberDiff line numberDiff line change
@@ -66,4 +66,4 @@ suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
6666
suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
6767

6868
[version]
69-
^0.92.0
69+
^0.93.0

‎yarn.lock

+4-4
Original file line numberDiff line numberDiff line change
@@ -2801,10 +2801,10 @@ flat-cache@^1.2.1:
28012801
graceful-fs "^4.1.2"
28022802
write "^0.2.1"
28032803

2804-
flow-bin@^0.92.0:
2805-
version "0.92.0"
2806-
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.92.0.tgz#f5bf3e808b17b480e067ac673829ca715a168bea"
2807-
integrity sha512-3ErXSAXZZlLV5/QPlaUDCWlDUXop1SiH32ifXL3SEiBwsmGbudCLim+HFVZfkegrn1nB4TcNSkMWtW8SnMPyAQ==
2804+
flow-bin@^0.93.0:
2805+
version "0.93.0"
2806+
resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.93.0.tgz#9192a08d88db2a8da0ff55e42420f44539791430"
2807+
integrity sha512-p8yq4ocOlpyJgOEBEj0v0GzCP25c9WP0ilFQ8hXSbrTR7RPKuR+Whr+OitlVyp8ocdX0j1MrIwQ8x28dacy1pg==
28082808

28092809
flow-parser@0.*:
28102810
version "0.89.0"

0 commit comments

Comments
 (0)