Skip to content

Commit 9fee990

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Remove unneeded write to .version file (#39807)
Summary: Pull Request resolved: #39807 We used to need this file so that we could read the react native version when [creating Hermes artifacts](e4b5d3e#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47R1507). Originally, that change was introduced [here](e4b5d3e#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47) Despite the fact that that approach was wrong, as we already have the right version in the package.json which is guaranteed to be present, a lot has changed since then and we don't need that file anymore. ## Changelog: [Internal] - Remove lines that write a .version file while releasing on npm Reviewed By: lunaleaps Differential Revision: D49909718 fbshipit-source-id: bd23d6d73001d0b58bf6b0321ed6d4ceb3523e7a
1 parent ed9931f commit 9fee990

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

scripts/publish-npm.js

-4
Original file line numberDiff line numberDiff line change
@@ -81,10 +81,6 @@ function publishNpm(buildType) {
8181

8282
generateAndroidArtifacts(version);
8383

84-
// Write version number to the build folder
85-
const versionFile = path.join('build', '.version');
86-
fs.writeFileSync(versionFile, version);
87-
8884
if (buildType === 'dry-run') {
8985
echo('Skipping `npm publish` because --dry-run is set.');
9086
return exit(0);

0 commit comments

Comments
 (0)