Fix ReactLegacy and delete RCTViewControllerProtocol

Summary:
It's always bothered that we have this protocol and I figured it could just be merged with RCTWrapperViewController.
Closes #17290

Reviewed By: mmmulani

Differential Revision: D6611544

Pulled By: javache

fbshipit-source-id: a50b9d5adbeb2c48dbadbbfc1c77ccf6d1aae144

Author: javache

RNTester/RNTester.xcodeproj/project.pbxproj

@@ -412,6 +412,20 @@
 			remoteGlobalIDString = 3DBE0D0D1F3B181C0099AA32;
 			remoteInfo = "fishhook-tvOS";
 		};
+		3DCE53211FEAB1C500613583 /* PBXContainerItemProxy */ = {
+			isa = PBXContainerItemProxy;
+			containerPortal = 14AADEFF1AC3DB95002390C9 /* React.xcodeproj */;
+			proxyType = 2;
+			remoteGlobalIDString = EBF21BDC1FC498900052F4D5;
+			remoteInfo = jsinspector;
+		};
+		3DCE53231FEAB1C500613583 /* PBXContainerItemProxy */ = {
+			isa = PBXContainerItemProxy;
+			containerPortal = 14AADEFF1AC3DB95002390C9 /* React.xcodeproj */;
+			proxyType = 2;
+			remoteGlobalIDString = EBF21BFA1FC4989A0052F4D5;
+			remoteInfo = "jsinspector-tvOS";
+		};
 		5281CA501EEAC9A700AC40CD /* PBXContainerItemProxy */ = {
 			isa = PBXContainerItemProxy;
 			containerPortal = 5281CA4B1EEAC9A700AC40CD /* RCTBlob.xcodeproj */;
@@ -826,6 +840,8 @@
 				3D05748E1DE6008900184BB4 /* libcxxreact.a */,
 				3D0574901DE6008900184BB4 /* libjschelpers.a */,
 				3D0574921DE6008900184BB4 /* libjschelpers.a */,
+				3DCE53221FEAB1C500613583 /* libjsinspector.a */,
+				3DCE53241FEAB1C500613583 /* libjsinspector-tvOS.a */,
 				3D507F421EBC88B700B56834 /* libthird-party.a */,
 				2D66FF8C1ECA405900F0A767 /* libthird-party.a */,
 				3D507F441EBC88B700B56834 /* libdouble-conversion.a */,
@@ -1497,6 +1513,20 @@
 			remoteRef = 3DBE0D341F3B18670099AA32 /* PBXContainerItemProxy */;
 			sourceTree = BUILT_PRODUCTS_DIR;
 		};
+		3DCE53221FEAB1C500613583 /* libjsinspector.a */ = {
+			isa = PBXReferenceProxy;
+			fileType = archive.ar;
+			path = libjsinspector.a;
+			remoteRef = 3DCE53211FEAB1C500613583 /* PBXContainerItemProxy */;
+			sourceTree = BUILT_PRODUCTS_DIR;
+		};
+		3DCE53241FEAB1C500613583 /* libjsinspector-tvOS.a */ = {
+			isa = PBXReferenceProxy;
+			fileType = archive.ar;
+			path = "libjsinspector-tvOS.a";
+			remoteRef = 3DCE53231FEAB1C500613583 /* PBXContainerItemProxy */;
+			sourceTree = BUILT_PRODUCTS_DIR;
+		};
 		5281CA511EEAC9A700AC40CD /* libRCTBlob.a */ = {
 			isa = PBXReferenceProxy;
 			fileType = archive.ar;

RNTester/RNTesterLegacy.xcodeproj/project.pbxproj

@@ -110,6 +110,7 @@
 		3D4153641F277011005B8EFE /* libART-tvOS.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 3D4153621F276FF9005B8EFE /* libART-tvOS.a */; };
 		3D56F9F11D6F6E9B00F53A06 /* RNTesterBundle.bundle in Resources */ = {isa = PBXBuildFile; fileRef = 3D13F83E1D6F6AE000E69E0E /* RNTesterBundle.bundle */; };
 		3DB99D0C1BA0340600302749 /* RNTesterIntegrationTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 3DB99D0B1BA0340600302749 /* RNTesterIntegrationTests.m */; };
+		3DCE52BC1FEAAF8F00613583 /* libReact.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 1380DC9B1E70C0DD00E7C47D /* libReact.a */; };
 		3DD981D61D33C6FB007DC7BE /* RNTesterUnitTestsBundle.js in Resources */ = {isa = PBXBuildFile; fileRef = 3DD981D51D33C6FB007DC7BE /* RNTesterUnitTestsBundle.js */; };
 		68FF44381CF6111500720EFD /* RCTBundleURLProviderTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 68FF44371CF6111500720EFD /* RCTBundleURLProviderTests.m */; };
 		834C36EC1AF8DED70019C93C /* libRCTSettings.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 834C36D21AF8DA610019C93C /* libRCTSettings.a */; };
@@ -535,6 +536,7 @@
 			isa = PBXFrameworksBuildPhase;
 			buildActionMask = 2147483647;
 			files = (
+				3DCE52BC1FEAAF8F00613583 /* libReact.a in Frameworks */,
 				3D4153641F277011005B8EFE /* libART-tvOS.a in Frameworks */,
 				2DD323E31DA2DE3F000FE1B8 /* libRCTAnimation.a in Frameworks */,
 				3D302F221DF8285100D6DDAE /* libRCTImage-tvOS.a in Frameworks */,
@@ -833,6 +835,13 @@
 			name = Products;
 			sourceTree = "<group>";
 		};
+		3DCE52B31FEAAF8F00613583 /* Frameworks */ = {
+			isa = PBXGroup;
+			children = (
+			);
+			name = Frameworks;
+			sourceTree = "<group>";
+		};
 		58005BE51ABA80530062E044 /* Products */ = {
 			isa = PBXGroup;
 			children = (
@@ -862,6 +871,7 @@
 				14D6D6EA1B2205C0001FB087 /* OCMock */,
 				2DD323911DA2DD8B000FE1B8 /* RNTester-tvOS */,
 				83CBBA001A601CBA00E9B192 /* Products */,
+				3DCE52B31FEAAF8F00613583 /* Frameworks */,
 			);
 			indentWidth = 2;
 			sourceTree = "<group>";

React/Modules/RCTRedBoxExtraDataViewController.m

@@ -41,9 +41,12 @@ - (instancetype)initWithStyle:(UITableViewCellStyle)style
             constraintEqualToAnchor:contentLayout.widthAnchor
             multiplier:0.3].active = YES;
 
+
         self.keyLabel.textColor = [UIColor whiteColor];
         self.keyLabel.numberOfLines = 0;
+#if !TARGET_OS_TV
         self.keyLabel.lineBreakMode = UILineBreakModeWordWrap;
+#endif
         self.keyLabel.font = [UIFont fontWithName:@"Menlo-Regular" size:12.0f];
 
         self.valueLabel = [UILabel new];
@@ -62,7 +65,9 @@ - (instancetype)initWithStyle:(UITableViewCellStyle)style
 
         self.valueLabel.textColor = [UIColor whiteColor];
         self.valueLabel.numberOfLines = 0;
+#if !TARGET_OS_TV
         self.valueLabel.lineBreakMode = UILineBreakModeWordWrap;
+#endif
         self.valueLabel.font = [UIFont fontWithName:@"Menlo-Regular" size:12.0f];
     }
     return self;
@@ -98,7 +103,9 @@ - (instancetype)init
         _tableView.dataSource = self;
         _tableView.backgroundColor = [UIColor clearColor];
         _tableView.estimatedRowHeight = 200;
+#if !TARGET_OS_TV
         _tableView.separatorStyle = UITableViewCellSeparatorStyleNone;
+#endif
         _tableView.rowHeight = UITableViewAutomaticDimension;
         _tableView.allowsSelection = NO;