Fixed HTTP connection timeout on Android (#22164)

Eric Butler · facebook-github-bot · commit a50813472450 · 2018-11-14T00:43:35.000-08:00
Summary: Fixes #11666 (Which was incorrectly closed) Pull Request resolved: #22164 Differential Revision: D13057001 Pulled By: hramos fbshipit-source-id: bcd53e893bc7c114f866e54938166b74b8ae0299
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/network/NetworkingModule.java
@@ -325,7 +325,7 @@ public void onProgress(long bytesWritten, long contentLength, boolean done) {
     // shared under the hood.
     // See https://github.com/square/okhttp/wiki/Recipes#per-call-configuration for more information
     if (timeout != mClient.connectTimeoutMillis()) {
-      clientBuilder.readTimeout(timeout, TimeUnit.MILLISECONDS);
+      clientBuilder.connectTimeout(timeout, TimeUnit.MILLISECONDS);
     }
     OkHttpClient client = clientBuilder.build();
 

Original file line number	Diff line number	Diff line change
`@@ -325,7 +325,7 @@ public void onProgress(long bytesWritten, long contentLength, boolean done) {`
`325`	`325`	`// shared under the hood.`
`326`	`326`	`// See https://github.com/square/okhttp/wiki/Recipes#per-call-configuration for more information`
`327`	`327`	`if (timeout != mClient.connectTimeoutMillis()) {`
`328`		`- clientBuilder.readTimeout(timeout, TimeUnit.MILLISECONDS);`
	`328`	`+ clientBuilder.connectTimeout(timeout, TimeUnit.MILLISECONDS);`
`329`	`329`	`}`
`330`	`330`	`OkHttpClient client = clientBuilder.build();`
`331`	`331`