Skip to content

Commit a51e8b1

Browse files
elicwhitefacebook-github-bot
authored andcommitted
Don't pass additional args to requireNativeComponent in .android.js files
Reviewed By: sahrens Differential Revision: D8345921 fbshipit-source-id: 187048ad4c1b361f0b99b993052bdcaf47a266db
1 parent 6b1bb01 commit a51e8b1

File tree

11 files changed

+17
-100
lines changed

11 files changed

+17
-100
lines changed

Libraries/Components/CheckBox/CheckBox.android.js

+2-8
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ const ViewPropTypes = require('ViewPropTypes');
1818
const createReactClass = require('create-react-class');
1919
const requireNativeComponent = require('requireNativeComponent');
2020

21+
const RCTCheckBox = requireNativeComponent('AndroidCheckBox');
22+
2123
type DefaultProps = {
2224
value: boolean,
2325
disabled: boolean,
@@ -155,12 +157,4 @@ let styles = StyleSheet.create({
155157
},
156158
});
157159

158-
let RCTCheckBox = requireNativeComponent('AndroidCheckBox', CheckBox, {
159-
nativeOnly: {
160-
onChange: true,
161-
on: true,
162-
enabled: true,
163-
},
164-
});
165-
166160
module.exports = CheckBox;

Libraries/Components/DrawerAndroid/DrawerLayoutAndroid.android.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -321,9 +321,6 @@ const styles = StyleSheet.create({
321321
});
322322

323323
// The View that contains both the actual drawer and the main view
324-
const AndroidDrawerLayout = requireNativeComponent(
325-
'AndroidDrawerLayout',
326-
DrawerLayoutAndroid,
327-
);
324+
const AndroidDrawerLayout = requireNativeComponent('AndroidDrawerLayout');
328325

329326
module.exports = DrawerLayoutAndroid;

Libraries/Components/Picker/PickerAndroid.android.js

+3-18
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,9 @@ const ViewStylePropTypes = require('ViewStylePropTypes');
2121
const processColor = require('processColor');
2222
const requireNativeComponent = require('requireNativeComponent');
2323

24+
const DropdownPicker = requireNativeComponent('AndroidDropdownPicker');
25+
const DialogPicker = requireNativeComponent('AndroidDialogPicker');
26+
2427
const REF_PICKER = 'picker';
2528
const MODE_DROPDOWN = 'dropdown';
2629

@@ -158,22 +161,4 @@ const styles = StyleSheet.create({
158161
},
159162
});
160163

161-
const cfg = {
162-
nativeOnly: {
163-
items: true,
164-
selected: true,
165-
},
166-
};
167-
168-
const DropdownPicker = requireNativeComponent(
169-
'AndroidDropdownPicker',
170-
PickerAndroid,
171-
cfg,
172-
);
173-
const DialogPicker = requireNativeComponent(
174-
'AndroidDialogPicker',
175-
PickerAndroid,
176-
cfg,
177-
);
178-
179164
module.exports = PickerAndroid;

Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js

+1-10
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
const ColorPropType = require('ColorPropType');
1313
const PropTypes = require('prop-types');
1414
const React = require('React');
15-
const ReactNative = require('ReactNative');
1615
const ViewPropTypes = require('ViewPropTypes');
1716

1817
const requireNativeComponent = require('requireNativeComponent');
@@ -115,15 +114,7 @@ class ProgressBarAndroid extends React.Component {
115114
}
116115
}
117116

118-
const AndroidProgressBar = requireNativeComponent(
119-
'AndroidProgressBar',
120-
ProgressBarAndroid,
121-
{
122-
nativeOnly: {
123-
animating: true,
124-
},
125-
},
126-
);
117+
const AndroidProgressBar = requireNativeComponent('AndroidProgressBar');
127118

128119
module.exports = React.forwardRef((props, ref) => (
129120
<ProgressBarAndroid {...props} forwardedRef={ref} />

Libraries/Components/TabBarIOS/TabBarItemIOS.ios.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -143,6 +143,6 @@ const styles = StyleSheet.create({
143143
},
144144
});
145145

146-
const RCTTabBarItem = requireNativeComponent('RCTTabBarItem', TabBarItemIOS);
146+
const RCTTabBarItem = requireNativeComponent('RCTTabBarItem');
147147

148148
module.exports = TabBarItemIOS;

Libraries/Components/ToolbarAndroid/ToolbarAndroid.android.js

+1-6
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ const Image = require('Image');
1313
const NativeMethodsMixin = require('NativeMethodsMixin');
1414
const React = require('React');
1515
const PropTypes = require('prop-types');
16-
const ReactNativeViewAttributes = require('ReactNativeViewAttributes');
1716
const UIManager = require('UIManager');
1817
const ViewPropTypes = require('ViewPropTypes');
1918
const ColorPropType = require('ColorPropType');
@@ -207,10 +206,6 @@ const ToolbarAndroid = createReactClass({
207206
},
208207
});
209208

210-
const NativeToolbar = requireNativeComponent('ToolbarAndroid', ToolbarAndroid, {
211-
nativeOnly: {
212-
nativeActions: true,
213-
},
214-
});
209+
const NativeToolbar = requireNativeComponent('ToolbarAndroid');
215210

216211
module.exports = ToolbarAndroid;

Libraries/Components/ViewPager/ViewPagerAndroid.android.js

+2-5
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@ const ViewPropTypes = require('ViewPropTypes');
1919
const dismissKeyboard = require('dismissKeyboard');
2020
const requireNativeComponent = require('requireNativeComponent');
2121

22+
const NativeAndroidViewPager = requireNativeComponent('AndroidViewPager');
23+
2224
const VIEWPAGER_REF = 'viewPager';
2325

2426
type Event = Object;
@@ -255,9 +257,4 @@ class ViewPagerAndroid extends React.Component<{
255257
}
256258
}
257259

258-
const NativeAndroidViewPager = requireNativeComponent(
259-
'AndroidViewPager',
260-
ViewPagerAndroid,
261-
);
262-
263260
module.exports = ViewPagerAndroid;

Libraries/Components/WebView/WebView.android.js

+1-13
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,6 @@ const defaultRenderLoading = () => (
4343
* Renders a native WebView.
4444
*/
4545
class WebView extends React.Component {
46-
static get extraNativeComponentConfig() {
47-
return {
48-
nativeOnly: {
49-
messagingEnabled: PropTypes.bool,
50-
},
51-
};
52-
}
53-
5446
static propTypes = {
5547
...ViewPropTypes,
5648
renderError: PropTypes.func,
@@ -464,11 +456,7 @@ class WebView extends React.Component {
464456
};
465457
}
466458

467-
const RCTWebView = requireNativeComponent(
468-
'RCTWebView',
469-
WebView,
470-
WebView.extraNativeComponentConfig,
471-
);
459+
const RCTWebView = requireNativeComponent('RCTWebView');
472460

473461
const styles = StyleSheet.create({
474462
container: {

Libraries/Components/WebView/WebView.ios.js

+1-17
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,6 @@ const defaultRenderError = (errorDomain, errorCode, errorDesc) => (
109109
class WebView extends React.Component {
110110
static JSNavigationScheme = JSNavigationScheme;
111111
static NavigationType = NavigationType;
112-
static get extraNativeComponentConfig() {
113-
return {
114-
nativeOnly: {
115-
onLoadingStart: true,
116-
onLoadingError: true,
117-
onLoadingFinish: true,
118-
onMessage: true,
119-
messagingEnabled: PropTypes.bool,
120-
},
121-
};
122-
}
123-
124112
static propTypes = {
125113
...ViewPropTypes,
126114

@@ -651,11 +639,7 @@ class WebView extends React.Component {
651639
};
652640
}
653641

654-
const RCTWebView = requireNativeComponent(
655-
'RCTWebView',
656-
WebView,
657-
WebView.extraNativeComponentConfig,
658-
);
642+
const RCTWebView = requireNativeComponent('RCTWebView');
659643

660644
const styles = StyleSheet.create({
661645
container: {

Libraries/Image/Image.android.js

+3-16
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ const resolveAssetSource = require('resolveAssetSource');
2929

3030
const {ImageLoader} = NativeModules;
3131

32+
const RKImage = requireNativeComponent('RCTImageView');
33+
const RCTTextInlineImage = requireNativeComponent('RCTTextInlineImage');
34+
3235
let _requestId = 1;
3336
function generateRequestId() {
3437
return _requestId++;
@@ -278,20 +281,4 @@ const styles = StyleSheet.create({
278281
},
279282
});
280283

281-
const cfg = {
282-
nativeOnly: {
283-
src: true,
284-
headers: true,
285-
defaultSrc: true,
286-
loadingIndicatorSrc: true,
287-
shouldNotifyLoadEvents: true,
288-
},
289-
};
290-
const RKImage = requireNativeComponent('RCTImageView', Image, cfg);
291-
const RCTTextInlineImage = requireNativeComponent(
292-
'RCTTextInlineImage',
293-
Image,
294-
cfg,
295-
);
296-
297284
module.exports = Image;

ReactAndroid/src/androidTest/js/SubviewsClippingTestModule.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,13 @@
1111

1212
var BatchedBridge = require('BatchedBridge');
1313
var React = require('React');
14-
var ReactNativeViewAttributes = require('ReactNativeViewAttributes');
1514
var ScrollView = require('ScrollView');
1615
var StyleSheet = require('StyleSheet');
1716
var View = require('View');
1817

1918
var requireNativeComponent = require('requireNativeComponent');
2019

21-
var ClippableView = requireNativeComponent('ClippableView', null);
20+
var ClippableView = requireNativeComponent('ClippableView');
2221

2322
class ClippingSample1 extends React.Component {
2423
render() {

0 commit comments

Comments
 (0)